merge: Merge pull request #210 from arunaengine/fix/cors-rules-allowe… #389
codecov.yml
on: push
Generate Coverage Report
6m 14s
Annotations
35 warnings
|
hiding a lifetime that's elided elsewhere is confusing:
components/server/src/caching/cache.rs#L867
warning: hiding a lifetime that's elided elsewhere is confusing
--> components/server/src/caching/cache.rs:867:9
|
867 | &self,
| ^^^^^ the lifetime is elided here
...
870 | ) -> ProxyCacheIterator {
| ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
|
870 | ) -> ProxyCacheIterator<'_> {
| ++++
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L376
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:376:54
|
376 | pub fn query(cache: &Arc<Cache>, id: &DieselUlid) -> Result<generic_resource::Resource, Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L359
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:359:44
|
359 | pub fn get_id_and_ctx(ids: Vec<String>) -> Result<(Vec<DieselUlid>, Vec<Context>)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L35
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:35:28
|
35 | fn into_inner(self) -> Result<T, Status>;
| ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
|
|
`to_string` applied to a type that implements `Display` in `anyhow!` args:
components/server/src/middlelayer/rule_db_handler.rs#L234
warning: `to_string` applied to a type that implements `Display` in `anyhow!` args
--> components/server/src/middlelayer/rule_db_handler.rs:234:78
|
234 | .map_err(|e| anyhow!(format!("Policy evaluation error: {}", e.to_string())))?;
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#to_string_in_format_args
|
|
this function has too many arguments (8/7):
components/server/src/middlelayer/hooks_request_types.rs#L318
warning: this function has too many arguments (8/7)
--> components/server/src/middlelayer/hooks_request_types.rs:318:5
|
318 | / pub fn create_custom_template(
319 | | input: String,
320 | | hook_id: DieselUlid,
321 | | object: &Object,
... |
326 | | pubkey_serial: i32,
327 | | ) -> Result<String> {
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
the `Err`-variant returned from this function is very large:
components/server/src/middlelayer/create_request_types.rs#L151
warning: the `Err`-variant returned from this function is very large
--> components/server/src/middlelayer/create_request_types.rs:151:44
|
151 | pub fn get_relation_contexts(&self) -> Result<Vec<Context>, tonic::Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
|
|
use of a fallible conversion when an infallible one could be used:
components/server/src/middlelayer/announcements_db_handler.rs#L72
warning: use of a fallible conversion when an infallible one could be used
--> components/server/src/middlelayer/announcements_db_handler.rs:72:25
|
72 | Ok(announcement.try_into()?)
| ^^^^^^^^ help: use: `into`
|
= note: converting `Announcement` to `Announcement` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
the `Err`-variant returned from this function is very large:
components/server/src/grpc/notification.rs#L672
warning: the `Err`-variant returned from this function is very large
--> components/server/src/grpc/notification.rs:672:6
|
672 | ) -> Result<EventMessage, Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/grpc/notification.rs#L627
warning: the `Err`-variant returned from this function is very large
--> components/server/src/grpc/notification.rs:627:6
|
627 | ) -> Result<(Context, EventType), Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
|
|
`to_string` applied to a type that implements `Display` in `anyhow!` args:
components/server/src/caching/cache.rs#L401
warning: `to_string` applied to a type that implements `Display` in `anyhow!` args
--> components/server/src/caching/cache.rs:401:32
|
401 | issuer_name.to_string()
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
doc list item overindented:
components/server/src/auth/token_handler.rs#L53
warning: doc list item overindented
--> components/server/src/auth/token_handler.rs:53:5
|
53 | /// Strongly restricts the usability of the token.
| ^^^^^^^^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
name `REPLICATIONOUT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L270
warning: name `REPLICATIONOUT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:270:5
|
270 | REPLICATIONOUT,
| ^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Replicationout`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
|
|
name `REPLICATIONIN` contains a capitalized acronym:
components/data_proxy/src/config.rs#L269
warning: name `REPLICATIONIN` contains a capitalized acronym
--> components/data_proxy/src/config.rs:269:5
|
269 | REPLICATIONIN,
| ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Replicationin`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
|
|
name `BUNDLE` contains a capitalized acronym:
components/data_proxy/src/config.rs#L268
warning: name `BUNDLE` contains a capitalized acronym
--> components/data_proxy/src/config.rs:268:5
|
268 | BUNDLE,
| ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bundle`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
|
|
name `OBJECTPACKAGE` contains a capitalized acronym:
components/data_proxy/src/config.rs#L267
warning: name `OBJECTPACKAGE` contains a capitalized acronym
--> components/data_proxy/src/config.rs:267:5
|
267 | OBJECTPACKAGE,
| ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Objectpackage`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
|
|
name `OBJECT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L266
warning: name `OBJECT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:266:5
|
266 | OBJECT,
| ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
|
|
name `ROOT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L265
warning: name `ROOT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:265:5
|
265 | ROOT, // Info
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Root`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
|
module has the same name as its containing module:
components/data_proxy/src/auth/mod.rs#L1
warning: module has the same name as its containing module
--> components/data_proxy/src/auth/mod.rs:1:1
|
1 | pub mod auth;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
|
large size difference between variants:
components/data_proxy/src/structs.rs#L1661
warning: large size difference between variants
--> components/data_proxy/src/structs.rs:1661:1
|
1661 | / pub enum ObjectsState {
1662 | | / Regular {
1663 | | | states: ResourceStates,
1664 | | | location: Option<ObjectLocation>,
1665 | | | },
| | |_____- the largest variant contains at least 1768 bytes
1666 | | / Objects {
1667 | | | root: Object,
1668 | | | filename: String,
1669 | | | },
| | |_____- the second-largest variant contains at least 424 bytes
... |
1673 | | },
1674 | | }
| |___^ the entire enum is at least 1768 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
1663 - states: ResourceStates,
1663 + states: Box<ResourceStates>,
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/structs.rs#L1557
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/structs.rs:1557:10
|
1557 | ) -> Result<
| __________^
1558 | | (
1559 | | NewOrExistingObject,
1560 | | NewOrExistingObject,
... |
1565 | | S3Error,
1566 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#type_complexity
|
|
large size difference between variants:
components/data_proxy/src/structs.rs#L1238
warning: large size difference between variants
--> components/data_proxy/src/structs.rs:1238:1
|
1238 | / pub enum ResourceState {
1239 | | / Found {
1240 | | | object: Object,
1241 | | | },
| | |_____- the largest variant contains at least 400 bytes
1242 | | / Missing {
1243 | | | name: String,
1244 | | | variant: ResourceVariant,
1245 | | | },
| | |_____- the second-largest variant contains at least 28 bytes
1246 | | #[default]
1247 | | None,
1248 | | }
| |___^ the entire enum is at least 400 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
1240 - object: Object,
1240 + object: Box<Object>,
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/structs.rs#L402
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/structs.rs:402:10
|
402 | ) -> (
| __________^
403 | | Vec<(String, HashMap<DieselUlid, DbPermissionLevel>)>,
404 | | Vec<String>,
405 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#type_complexity
|
|
manual implementation of `.is_multiple_of()`:
components/data_proxy/src/structs.rs#L264
warning: manual implementation of `.is_multiple_of()`
--> components/data_proxy/src/structs.rs:264:20
|
264 | if (self.disk_content_len as usize + 109) % (65536 + 28) == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.disk_content_len as usize + 109).is_multiple_of(65536 + 28)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_is_multiple_of
|
|
manual implementation of `.is_multiple_of()`:
components/data_proxy/src/structs.rs#L256
warning: manual implementation of `.is_multiple_of()`
--> components/data_proxy/src/structs.rs:256:20
|
256 | if (self.raw_content_len as usize + 109) % (65536 + 28) == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.raw_content_len as usize + 109).is_multiple_of(65536 + 28)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_is_multiple_of
|
|
manual implementation of `.is_multiple_of()`:
components/data_proxy/src/structs.rs#L247
warning: manual implementation of `.is_multiple_of()`
--> components/data_proxy/src/structs.rs:247:20
|
247 | if self.disk_content_len as usize % 65536 == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.disk_content_len as usize).is_multiple_of(65536)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_is_multiple_of
|
|
manual implementation of `.is_multiple_of()`:
components/data_proxy/src/structs.rs#L240
warning: manual implementation of `.is_multiple_of()`
--> components/data_proxy/src/structs.rs:240:20
|
240 | if self.raw_content_len as usize % 65536 == 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.raw_content_len as usize).is_multiple_of(65536)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/s3_frontend/utils/ranges.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/s3_frontend/utils/ranges.rs:22:6
|
22 | ) -> Result<(Option<String>, Option<Vec<u64>>, u64, Option<ArunaRange>)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
taken reference of right operand:
components/data_proxy/src/s3_frontend/s3server.rs#L317
warning: taken reference of right operand
--> components/data_proxy/src/s3_frontend/s3server.rs:317:28
|
317 | || req.method() == &Method::OPTIONS)
| ^^^^^^^^^^^^^^^^----------------
| |
| help: use the right value directly: `Method::OPTIONS`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
|
struct `MakeService` is never constructed:
components/data_proxy/src/s3_frontend/s3server.rs#L201
warning: struct `MakeService` is never constructed
--> components/data_proxy/src/s3_frontend/s3server.rs:201:12
|
201 | pub struct MakeService<S>(S);
| ^^^^^^^^^^^
|
|
trait `IntoHashMap` is never used:
components/data_proxy/src/caching/transforms.rs#L36
warning: trait `IntoHashMap` is never used
--> components/data_proxy/src/caching/transforms.rs:36:11
|
36 | pub trait IntoHashMap {
| ^^^^^^^^^^^
|
|
trait `GetId` is never used:
components/data_proxy/src/caching/transforms.rs#L18
warning: trait `GetId` is never used
--> components/data_proxy/src/caching/transforms.rs:18:11
|
18 | pub trait GetId {
| ^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
|
|
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.:
components/server/src/middlelayer/presigned_url_handler.rs#L430
warning: use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
--> components/server/src/middlelayer/presigned_url_handler.rs:430:60
|
430 | let config = aws_config::defaults(BehaviorVersion::v2024_03_28())
| ^^^^^^^^^^^
|
|
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.:
components/server/src/middlelayer/finish_db_handler.rs#L52
warning: use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
--> components/server/src/middlelayer/finish_db_handler.rs:52:60
|
52 | let config = aws_config::defaults(BehaviorVersion::v2024_03_28())
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
Generate Coverage Report
Cache not found for keys: v0-rust-report-Linux-x64-6f7daf8e-afbed0ef, v0-rust-report-Linux-x64-6f7daf8e
|