Skip to content

Commit 51776b8

Browse files
committed
fix: vary fallback S3 preflights by request headers
1 parent ee07154 commit 51776b8

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

api/src/cors.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ impl CorsConfig {
133133
header::ACCESS_CONTROL_MAX_AGE,
134134
HeaderValue::from(CORS_MAX_AGE.as_secs()),
135135
);
136-
headers.insert(header::VARY, HeaderValue::from_static("origin"));
136+
append_vary_headers(&mut headers, S3_PREFLIGHT_VARY);
137137
Some(headers)
138138
}
139139

@@ -268,5 +268,9 @@ mod tests {
268268
headers.get(header::ACCESS_CONTROL_ALLOW_HEADERS).unwrap(),
269269
&requested
270270
);
271+
assert_eq!(
272+
headers.get(header::VARY).unwrap(),
273+
"Origin, Access-Control-Request-Method, Access-Control-Request-Headers"
274+
);
271275
}
272276
}

0 commit comments

Comments
 (0)