Commit b4319b0
committed
Improve: Pick SVE over NEON by measured register width
`SZ_ENFORCE_SVE_OVER_NEON` pretended to be a global policy switch but only
half the kernel families honored it (compare, memory, find, UTF-8 tokens -
not hash or intersect), its "enforce everywhere" README promise was false,
and as a compile-time constant it answered a question that is inherently
per-machine: whether the scalable kernels beat NEON depends on the SVE
register width, which Arm implementations choose freely.
Replace the flag with the width question asked directly, once per dispatch
context:
- Runtime dispatch measures the running CPU with `svcntb` through the new
`sz_sve_wider_than_neon_` helper in `dispatch.h`, next to the dispatch
table it serves. At the common 128-bit vector length the length-sensitive
families keep their faster NEON kernels; wider implementations get the
scalable ones automatically.
- Compile-time dispatch consults `SZ_SVE_WIDER_THAN_NEON_` in `types.h`,
driven by `__ARM_FEATURE_SVE_BITS` when the width is pinned via
`-msve-vector-bits=N`; unpinned builds assume the common 128-bit case and
keep NEON, matching the flag's old default behavior bit for bit.
The crypto-heavy families are untouched and prefer SVE2 at any width. On
128-bit implementations like Graviton 4 the four families now stay on NEON,
matching measurements; on wider ones like Graviton 3 (256-bit) or A64FX
(512-bit) the scalable kernels are finally selected automatically - a
combination the old default could never reach. To force a specific backend
regardless, the `SZ_USE_SVE`/`SZ_USE_SVE2`/`SZ_USE_NEON` toggles remain.
Verified with all Arm tiers enabled across all sixteen C translation units
under Clang 20 at a plain `armv8-a` baseline, GCC 12 on Linux-Arm with
`-Werror=implicit-function-declaration`, and both Cargo dispatch modes.1 parent 124d7e9 commit b4319b0
11 files changed
Lines changed: 57 additions & 23 deletions
File tree
- c/stringzilla
- include/stringzilla
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
111 | 131 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
781 | 781 | | |
782 | 782 | | |
783 | 783 | | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
784 | 788 | | |
785 | 789 | | |
786 | 790 | | |
| |||
1011 | 1015 | | |
1012 | 1016 | | |
1013 | 1017 | | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | | - | |
1021 | 1018 | | |
1022 | 1019 | | |
1023 | 1020 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
| 200 | + | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
516 | | - | |
| 516 | + | |
517 | 517 | | |
518 | 518 | | |
519 | 519 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
417 | 417 | | |
418 | 418 | | |
419 | 419 | | |
420 | | - | |
| 420 | + | |
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
465 | 465 | | |
466 | 466 | | |
467 | 467 | | |
468 | | - | |
| 468 | + | |
469 | 469 | | |
470 | 470 | | |
471 | 471 | | |
| |||
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
492 | | - | |
| 492 | + | |
493 | 493 | | |
494 | 494 | | |
495 | 495 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
399 | 399 | | |
400 | 400 | | |
401 | 401 | | |
402 | | - | |
403 | | - | |
404 | | - | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
405 | 414 | | |
406 | 415 | | |
407 | 416 | | |
| |||
0 commit comments