Skip to content

fix: remove invalid x- fields from Kafka bindings example#1170

Closed
wei123-web wants to merge 2 commits intoasyncapi:masterfrom
wei123-web:fix-kafka-example-x-fields
Closed

fix: remove invalid x- fields from Kafka bindings example#1170
wei123-web wants to merge 2 commits intoasyncapi:masterfrom
wei123-web:fix-kafka-example-x-fields

Conversation

@wei123-web
Copy link
Copy Markdown


title: ""
---fix: remove invalid x- fields from Kafka bindings example


Related issue(s):
The ADEO Kafka example had invalid x- fields in Kafka bindings.
These fields are not allowed according to the Kafka binding JSON schema.
Removed x-key.subject.name.strategy and x-value.subject.name.strategy.

Related issue(s): #1164


Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link
Copy Markdown

@wei123-web
Copy link
Copy Markdown
Author

Hello! AsyncAPI maintainers

This PR fixes the ADEO Kafka example by removing invalid x- fields (x-key.subject.name.strategy and x-value.subject.name.strategy) from the Kafka bindings.
These fields are not allowed according to the Kafka binding JSON schema.

Thanks for reviewing!

@wei123-web wei123-web force-pushed the fix-kafka-example-x-fields branch from ed50b39 to 0c06140 Compare February 21, 2026 03:38
@wei123-web
Copy link
Copy Markdown
Author

Hello! maintainers
Rebasing done — branch is up to date and ready for review.
Thank you!

@sonarqubecloud
Copy link
Copy Markdown

@derberg
Copy link
Copy Markdown
Member

derberg commented Feb 24, 2026

Thanks for the contribution. I’m closing this PR because, while there is an existing issue, it was not approved or opened for contribution before the pull request was submitted.

Please make sure to follow the contribution guidelines, which explain when issues are considered ready for implementation and when pull requests are appropriate.

@derberg derberg closed this Feb 24, 2026
@wei123-web
Copy link
Copy Markdown
Author

got it I’ll follow the contribution guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants