fix: clarify null value handling in traits merge mechanism#1188
Closed
sahaiash wants to merge 2 commits intoasyncapi:masterfrom
Closed
fix: clarify null value handling in traits merge mechanism#1188sahaiash wants to merge 2 commits intoasyncapi:masterfrom
sahaiash wants to merge 2 commits intoasyncapi:masterfrom
Conversation
Resolves asyncapi#1178 by explicitly stating that null values in traits or target objects MUST be preserved as-is and MUST NOT be interpreted as deletion directives, regardless of JSON Merge Patch semantics. Added null value examples to the Traits Merge Mechanism section. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sahaiash
requested review from
GreenRover,
asyncapi-bot-eve,
char0n,
dalelane,
derberg and
fmvilas
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Member
|
@sahaiash thanks but atm I have to close the PR. We first need to discuss what the best approach is before we jump into PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullvalues in the trait merge mechanism #1178nullvalues in traits or target objects MUST be preserved as-isnullMUST NOT be interpreted as a deletion directive (unlike standard JSON Merge Patch semantics)Changes
spec/asyncapi.md— updated the Traits Merge Mechanism section (line ~2707) with a clarifying sentence and null value examplesTest plan
npm run validate:examples🤖 Generated with Claude Code