Merge pull request #133 from atlassian-labs/aqasimi/test-coverage

add unit tests for checks

Author: aqasimi

pkg/apis/atlassian/v1/cyclenoderequest.go

@@ -16,7 +16,7 @@ func (in *CycleNodeRequest) GetNodeGroupNames() []string {
 	return buildNodeGroupNames(in.Spec.NodeGroupsList, in.Spec.NodeGroupName)
 }
 
-// IsPartOfNodeGroup returns whether the CycleNodeRequest is part of the
+// IsFromNodeGroup returns whether the CycleNodeRequest is part of the
 // provided NodeGroup by comparing the list of named cloud provider nodegroups
 // defined in each one. Ordering does not affect equality.
 func (in *CycleNodeRequest) IsFromNodeGroup(nodegroup NodeGroup) bool {

pkg/controller/cyclenoderequest/transitioner/checks.go

@@ -127,7 +127,7 @@ func healthCheckPassed(healthCheck v1.HealthCheck, statusCode uint, body []byte)
 }
 
 // makeRequest makes the health check request to the endpoint specified, reads the body and returns
-// the status code/body to determinate weather it passed
+// the status code/body to determinate whether it passed
 func (t *CycleNodeRequestTransitioner) makeRequest(httpMethod string, httpClient *http.Client, endpoint string) (uint, []byte, error) {
 	httpReq, err := http.NewRequest(httpMethod, endpoint, nil)
 	if err != nil {
@@ -220,7 +220,7 @@ func (t *CycleNodeRequestTransitioner) performInitialHealthChecks(kubeNodes map[
 	for _, node := range t.cycleNodeRequest.Status.NodesToTerminate {
 		nodeHash := getNodeHash(node)
 
-		// Check if the node is ready, fail the cnr
+		// Check if the node is not ready, fail the cnr
 		_, ok := readyNodesSet[nodeHash]
 		if !ok {
 			return fmt.Errorf("node %s/%s not ready", nodeHash, node.Name)