src: cleanup ext_figma_for_jira_use_file_webhooks feature flag (#264)

* cache launchdarkly client

* clean up feature flag checks and update tests

Author: Isaiah-Turner

src/config/launch_darkly.ts

@@ -5,9 +5,14 @@ import { getLogger } from '../infrastructure';
 
 import { getConfig } from '.';
 
+let cachedClient: LDClient | null = null;
+
 export async function getLDClient(): Promise<LDClient | null> {
-	const ldSecretKey = getLaunchDarklySecretKey();
+	if (cachedClient) {
+		return cachedClient;
+	}
 
+	const ldSecretKey = getLaunchDarklySecretKey();
 	if (!ldSecretKey) {
 		getLogger().error(`No LaunchDarkly secret available.`);
 		return null;
@@ -23,7 +28,8 @@ export async function getLDClient(): Promise<LDClient | null> {
 	};
 	const client = init(ldSecretKey, options);
 	await client.waitForInitialization();
-	return client;
+	cachedClient = client;
+	return cachedClient;
 }
 
 export async function getFeatureFlag<T>(

src/usecases/handle-figma-file-update-event-use-case.test.ts

@@ -2,7 +2,6 @@ import { v4 as uuidv4 } from 'uuid';
 
 import { handleFigmaFileUpdateEventUseCase } from './handle-figma-file-update-event-use-case';
 
-import * as launchDarkly from '../config/launch_darkly';
 import { FigmaTeamAuthStatus } from '../domain/entities';
 import {
 	generateAssociatedFigmaDesign,
@@ -28,11 +27,6 @@ import type { FigmaWebhookInfo } from '../web/routes/figma';
 
 describe('handleFigmaFileUpdateEventUseCase', () => {
 	describe('file webhook', () => {
-		beforeEach(() => {
-			jest.spyOn(launchDarkly, 'getLDClient').mockResolvedValue(null);
-			jest.spyOn(launchDarkly, 'getFeatureFlag').mockResolvedValue(true);
-		});
-
 		it('should handle file webhook events', async () => {
 			const connectInstallation = generateConnectInstallation();
 			jest

src/usecases/handle-figma-file-update-event-use-case.ts

@@ -1,5 +1,4 @@
 import { uniqueWith } from '../common/array-utils';
-import { getFeatureFlag, getLDClient } from '../config/launch_darkly';
 import type { ConnectUserInfo } from '../domain/entities';
 import { FigmaTeamAuthStatus } from '../domain/entities';
 import { getLogger } from '../infrastructure';
@@ -60,16 +59,6 @@ export const handleFigmaFileUpdateEventUseCase = {
 			}
 
 			case 'file': {
-				const ldClient = await getLDClient();
-				const useFileWebhooks = await getFeatureFlag(
-					ldClient,
-					'ext_figma_for_jira_use_file_webhooks',
-					false,
-				);
-				if (!useFileWebhooks) {
-					return;
-				}
-
 				const figmaFileWebhook = webhookInfo.figmaFileWebhook;
 				return await syncDesignsToJira(
 					fileKey,

src/usecases/on-design-associated-with-issue-use-case.test.ts

@@ -5,7 +5,6 @@ import { InvalidInputUseCaseResultError } from './errors';
 import type { OnDesignAssociatedWithIssueUseCaseParams } from './on-design-associated-with-issue-use-case';
 import { onDesignAssociatedWithIssueUseCaseParams } from './on-design-associated-with-issue-use-case';
 
-import * as launch_darkly from '../config/launch_darkly';
 import {
 	type AssociatedFigmaDesign,
 	type FigmaFileWebhook,
@@ -61,11 +60,6 @@ const generateWebhookV2 = (
 });
 
 describe('onDesignAssociatedWithIssueUseCase', () => {
-	beforeEach(() => {
-		// set getFeatureFlag to return true for all feature flags
-		jest.spyOn(launch_darkly, 'getFeatureFlag').mockResolvedValue(true);
-	});
-
 	it('should store associated Design data, handle backward integration, and create file webhooks', async () => {
 		const figmaDesignId = generateFigmaDesignIdentifier();
 		const params = generateOnDesignAssociatedWithIssueUseCaseParams({

src/usecases/on-design-associated-with-issue-use-case.ts

@@ -2,7 +2,6 @@ import { v4 as uuidv4 } from 'uuid';
 
 import { InvalidInputUseCaseResultError } from './errors';
 
-import { getFeatureFlag, getLDClient } from '../config/launch_darkly';
 import type { ConnectInstallation } from '../domain/entities';
 import {
 	FigmaDesignIdentifier,
@@ -97,17 +96,6 @@ async function maybeCreateFigmaFileWebhooks(
 	atlassianUserId: string,
 	connectInstallationId: string,
 ): Promise<void> {
-	const ldClient = await getLDClient();
-	const useFileWebhooks = await getFeatureFlag(
-		ldClient,
-		'ext_figma_for_jira_use_file_webhooks',
-		false,
-	);
-
-	if (!useFileWebhooks) {
-		return;
-	}
-
 	const existingWebhook =
 		await figmaFileWebhookRepository.findByFileKeyAndEventTypeAndConnectInstallationId(
 			fileKey,

src/usecases/on-design-disassociated-from-issue-use-case.test.ts

@@ -4,7 +4,6 @@ import { InvalidInputUseCaseResultError } from './errors';
 import type { OnDesignDisassociatedFromIssueUseCaseParams } from './on-design-disassociated-from-issue-use-case';
 import { onDesignDisassociatedFromIssueUseCase } from './on-design-disassociated-from-issue-use-case';
 
-import * as launchDarkly from '../config/launch_darkly';
 import {
 	type AssociatedFigmaDesign,
 	FigmaFileWebhookEventType,
@@ -44,9 +43,6 @@ const generateOnDesignDisassociatedWithIssueUseCaseParams = ({
 
 describe('onDesignDisassociatedWithIssueUseCase', () => {
 	it('should delete stored associated Design data and handle backward integration', async () => {
-		jest.spyOn(launchDarkly, 'getLDClient').mockResolvedValue(null);
-		jest.spyOn(launchDarkly, 'getFeatureFlag').mockResolvedValue(true);
-
 		const figmaDesignId = generateFigmaDesignIdentifier();
 		const params = generateOnDesignDisassociatedWithIssueUseCaseParams({
 			designId: figmaDesignId.toAtlassianDesignId(),
@@ -126,9 +122,6 @@ describe('onDesignDisassociatedWithIssueUseCase', () => {
 	});
 
 	it('should not delete file webhooks more files rely on them', async () => {
-		jest.spyOn(launchDarkly, 'getLDClient').mockResolvedValue(null);
-		jest.spyOn(launchDarkly, 'getFeatureFlag').mockResolvedValue(true);
-
 		const figmaDesignId = generateFigmaDesignIdentifier();
 		const params = generateOnDesignDisassociatedWithIssueUseCaseParams({
 			designId: figmaDesignId.toAtlassianDesignId(),

src/usecases/on-design-disassociated-from-issue-use-case.ts

@@ -1,6 +1,5 @@
 import { InvalidInputUseCaseResultError } from './errors';
 
-import { getFeatureFlag, getLDClient } from '../config/launch_darkly';
 import type { ConnectInstallation } from '../domain/entities';
 import { FigmaDesignIdentifier } from '../domain/entities';
 import { figmaBackwardIntegrationServiceV2 } from '../infrastructure';
@@ -65,17 +64,6 @@ async function maybeTryDeleteFigmaFileWebhooks(
 	figmaDesignId: FigmaDesignIdentifier,
 	connectInstallationId: string,
 ): Promise<void> {
-	const ldClient = await getLDClient();
-	const useFileWebhooks = await getFeatureFlag(
-		ldClient,
-		'ext_figma_for_jira_use_file_webhooks',
-		false,
-	);
-
-	if (!useFileWebhooks) {
-		return;
-	}
-
 	const associatedDesigns =
 		await associatedFigmaDesignRepository.findManyByFileKeyAndConnectInstallationId(
 			figmaDesignId.fileKey,

src/web/routes/entities-v2/integration.test.ts

@@ -13,7 +13,6 @@ import {
 
 import app from '../../../app';
 import { buildAppUrl, getConfig } from '../../../config';
-import * as launchDarkly from '../../../config/launch_darkly';
 import {
 	buildJiraIssueUrl,
 	FigmaFileWebhookEventType,
@@ -353,6 +352,12 @@ describe('/entities', () => {
 					nodeId: '0:0',
 				}),
 			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
 
 			await request(app)
 				.put(buildAppUrl('entities/onEntityAssociated').pathname)
@@ -374,10 +379,7 @@ describe('/entities', () => {
 				.expect(HttpStatusCode.Ok);
 		});
 
-		it('should create Figma webhooks for the file when the feature flag is enabled', async () => {
-			jest.spyOn(launchDarkly, 'getLDClient').mockResolvedValue(null);
-			jest.spyOn(launchDarkly, 'getFeatureFlag').mockResolvedValue(true);
-
+		it('should create Figma webhooks for the file', async () => {
 			const connectInstallation = await connectInstallationRepository.upsert(
 				generateConnectInstallationCreateParams(),
 			);
@@ -524,6 +526,12 @@ describe('/entities', () => {
 				issueId,
 				status: HttpStatusCode.NotFound,
 			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
 
 			await request(app)
 				.put(buildAppUrl('entities/onEntityAssociated').pathname)
@@ -682,6 +690,12 @@ describe('/entities', () => {
 				}),
 				status: HttpStatusCode.Forbidden,
 			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
 
 			await request(app)
 				.put(buildAppUrl('entities/onEntityAssociated').pathname)
@@ -758,6 +772,12 @@ describe('/entities', () => {
 					nodeId: '0:0',
 				}),
 			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
+			mockFigmaCreateWebhookEndpoint({
+				baseUrl: getConfig().figma.apiBaseUrl,
+			});
 
 			await request(app)
 				.put(buildAppUrl('entities/onEntityAssociated').pathname)

src/web/routes/figma/integration.test.ts

@@ -13,7 +13,6 @@ import app from '../../../app';
 import { isNotNullOrUndefined } from '../../../common/predicates';
 import { isString } from '../../../common/string-utils';
 import { buildAppUrl, getConfig } from '../../../config';
-import * as launchDarkly from '../../../config/launch_darkly';
 import type {
 	AtlassianDesign,
 	ConnectInstallation,
@@ -603,11 +602,6 @@ describe('/figma', () => {
 	});
 
 	describe('/webhook/file', () => {
-		beforeEach(() => {
-			jest.spyOn(launchDarkly, 'getLDClient').mockResolvedValue(null);
-			jest.spyOn(launchDarkly, 'getFeatureFlag').mockResolvedValue(true);
-		});
-
 		describe('FILE_UPDATE event', () => {
 			const currentDate = new Date();
 			let connectInstallation: ConnectInstallation;