[HOT-304948] Fix empty namespace emitted as null

Author: rboustany-crypto

lib/src/main/java/graphql/nadel/result/NadelResultMerger.kt

@@ -121,12 +121,18 @@ internal object NadelResultMerger {
         // NOTE: please ensure all fields are from object types and will NOT have multiple field defs
         // Other code in this file relies on this contract
         for (field in topLevelFields) {
+            val namespaced = isNamespacedField(field, engineSchema)
+
+            if (namespaced && field.children.isEmpty()) {
+                continue
+            }
+
             val requiredChildFields = requiredFields
                 .computeIfAbsent(NadelResultKey(field.resultKey)) {
                     mutableListOf()
                 }
 
-            if (isNamespacedField(field, engineSchema)) {
+            if (namespaced) {
                 requiredChildFields.addAll(field.children)
             }
         }

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/namespaced/EmptyNamespaceIsOmittedTest.kt

@@ -0,0 +1,61 @@
+package graphql.nadel.tests.next.fixtures.namespaced
+
+import graphql.nadel.NadelExecutionHints
+import graphql.nadel.tests.next.NadelIntegrationTest
+
+/**
+ * Regression test for the HOT/bug where an empty namespace was materialised as `"jira": null`.
+ *
+ * When every child of a namespaced field is skipped (e.g. `@skip(if: true)`), the namespace has no
+ * children, no service call is made, and it must be OMITTED from the response entirely - NOT emitted
+ * as `jira: null`. Emitting `null` changed the response shape and tripped a downstream Relay non-null
+ * handler, turning the whole response into `data: null`.
+ *
+ * Expected result: `{ "hello": "world" }` with no `jira` key.
+ */
+class EmptyNamespaceIsOmittedTest : NadelIntegrationTest(
+    query = """
+        query {
+          hello
+          jira {
+            sprint @skip(if: true)
+          }
+        }
+    """.trimIndent(),
+    services = listOf(
+        Service(
+            name = "monolith",
+            overallSchema = """
+                type Query {
+                  hello: String
+                  jira: JiraQuery @namespaced
+                }
+                type JiraQuery {
+                  sprint: String
+                }
+            """.trimIndent(),
+            underlyingSchema = """
+                type Query {
+                  hello: String
+                  jira: JiraQuery
+                }
+                type JiraQuery {
+                  sprint: String
+                }
+            """.trimIndent(),
+            runtimeWiring = { wiring ->
+                wiring
+                    .type("Query") { type ->
+                        type
+                            .dataFetcher("hello") { "world" }
+                            .dataFetcher("jira") { emptyMap<String, Any?>() }
+                    }
+            },
+        ),
+    ),
+) {
+    override fun makeExecutionHints(): NadelExecutionHints.Builder {
+        return super.makeExecutionHints()
+            .newResultMergerAndNamespacedTypename { true }
+    }
+}

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/namespaced/EmptyNamespaceIsOmittedTestSnapshot.kt

@@ -0,0 +1,82 @@
+// @formatter:off
+package graphql.nadel.tests.next.fixtures.namespaced
+
+import graphql.nadel.tests.next.ExpectedNadelResult
+import graphql.nadel.tests.next.ExpectedServiceCall
+import graphql.nadel.tests.next.TestSnapshot
+import graphql.nadel.tests.next.listOfJsonStrings
+import kotlin.Suppress
+import kotlin.collections.List
+import kotlin.collections.listOf
+
+private suspend fun main() {
+    graphql.nadel.tests.next.update<EmptyNamespaceIsOmittedTest>()
+}
+
+/**
+ * This class is generated. Do NOT modify.
+ *
+ * Refer to [graphql.nadel.tests.next.UpdateTestSnapshots]
+ */
+@Suppress("unused")
+public class EmptyNamespaceIsOmittedTestSnapshot : TestSnapshot() {
+    /**
+     * Query
+     *
+     * ```graphql
+     * query {
+     *   hello
+     *   jira {
+     *     sprint @skip(if: true)
+     *   }
+     * }
+     * ```
+     *
+     * Variables
+     *
+     * ```json
+     * {}
+     * ```
+     */
+    override val calls: List<ExpectedServiceCall> = listOf(
+            ExpectedServiceCall(
+                service = "monolith",
+                query = """
+                | {
+                |   hello
+                | }
+                """.trimMargin(),
+                variables = "{}",
+                result = """
+                | {
+                |   "data": {
+                |     "hello": "world"
+                |   }
+                | }
+                """.trimMargin(),
+                delayedResults = listOfJsonStrings(
+                ),
+            ),
+        )
+
+    /**
+     * ```json
+     * {
+     *   "data": {
+     *     "hello": "world"
+     *   }
+     * }
+     * ```
+     */
+    override val result: ExpectedNadelResult = ExpectedNadelResult(
+            result = """
+            | {
+            |   "data": {
+            |     "hello": "world"
+            |   }
+            | }
+            """.trimMargin(),
+            delayedResults = listOfJsonStrings(
+            ),
+        )
+}