Skip to content

Commit 1f96177

Browse files
committed
fix(auth0-server-js): remove console.warn from logout catch blocks, strengthen revoke test assertion
1 parent a6cda83 commit 1f96177

2 files changed

Lines changed: 10 additions & 14 deletions

File tree

packages/auth0-server-js/src/server-client.spec.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6789,13 +6789,12 @@ describe('revokeRefreshToken', () => {
67896789
};
67906790

67916791
test('should revoke the refresh token from the session', async () => {
6792-
setupRevocation();
6793-
const mockStateStore = {
6794-
get: vi.fn(),
6795-
set: vi.fn(),
6796-
delete: vi.fn(),
6797-
deleteByLogoutToken: vi.fn(),
6798-
};
6792+
let capturedToken: string | null = null;
6793+
setupRevocation(async ({ request }) => {
6794+
const body = await request.formData();
6795+
capturedToken = body.get('token') as string;
6796+
return new HttpResponse(null, { status: 200 });
6797+
});
67996798

68006799
const stateData: StateData = {
68016800
user: { sub: '<sub>' },
@@ -6805,18 +6804,17 @@ describe('revokeRefreshToken', () => {
68056804
internal: { sid: '<sid>', createdAt: Date.now() },
68066805
};
68076806

6808-
mockStateStore.get.mockResolvedValue(stateData);
6809-
68106807
const serverClient = new ServerClient({
68116808
domain,
68126809
clientId: '<client_id>',
68136810
clientSecret: '<client_secret>',
68146811
discoveryCache: { ttl: 0 },
68156812
transactionStore: { get: vi.fn(), set: vi.fn(), delete: vi.fn() },
6816-
stateStore: mockStateStore,
6813+
stateStore: { get: vi.fn().mockResolvedValue(stateData), set: vi.fn(), delete: vi.fn(), deleteByLogoutToken: vi.fn() },
68176814
});
68186815

68196816
await expect(serverClient.revokeRefreshToken()).resolves.toBeUndefined();
6817+
expect(capturedToken).toBe('<refresh_token>');
68206818
});
68216819

68226820
test('should revoke an explicitly provided token', async () => {

packages/auth0-server-js/src/server-client.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,9 +1135,8 @@ export class ServerClient<TStoreOptions = unknown> {
11351135
if (!this.#isResolverMode()) {
11361136
try {
11371137
await this.revokeRefreshToken({}, storeOptions);
1138-
} catch (e) {
1138+
} catch {
11391139
// best-effort: revocation failure must not block logout
1140-
console.warn('revokeRefreshToken failed during logout (swallowed):', e);
11411140
}
11421141
await this.#stateStore.delete(this.#stateStoreIdentifier, storeOptions);
11431142
return this.authClient.buildLogoutUrl(options);
@@ -1158,9 +1157,8 @@ export class ServerClient<TStoreOptions = unknown> {
11581157
if (domainMatches) {
11591158
try {
11601159
await this.revokeRefreshToken({}, storeOptions);
1161-
} catch (e) {
1160+
} catch {
11621161
// best-effort: revocation failure must not block logout
1163-
console.warn('revokeRefreshToken failed during logout (swallowed):', e);
11641162
}
11651163
await this.#stateStore.delete(this.#stateStoreIdentifier, storeOptions);
11661164
}

0 commit comments

Comments
 (0)