chore(auth0-server-js): Remove obsolete MissingStoreOptionsError

Author: frederikprijck

packages/auth0-server-js/src/errors.ts

@@ -57,16 +57,4 @@ export class MissingSessionError extends Error {
     super(message);
     this.name = 'MissingSessionError';
   }
-}
-
-/**
- * Error thrown when the store options are missing.
- */
-export class MissingStoreOptionsError extends Error {
-  public code: string = 'missing_store_options_error';
-
-  constructor(message?: string) {
-    super(message ?? 'The store options are missing, making it impossible to interact with the store.');
-    this.name = 'MissingStoreOptionsError';
-  }
 }

packages/auth0-server-js/src/store/cookie-transaction-store.ts

@@ -1,4 +1,3 @@
-import { MissingStoreOptionsError } from './../errors.js';
 import type { EncryptedStoreOptions, TransactionData } from './../types.js';
 import { AbstractTransactionStore } from './abstract-transaction-store.js';
 import type { CookieHandler, CookieSerializeOptions } from './cookie-handler.js';
@@ -16,12 +15,7 @@ export class CookieTransactionStore<TStoreOptions> extends AbstractTransactionSt
     transactionData: TransactionData,
     removeIfExists?: boolean,
     options?: TStoreOptions
-  ): Promise<void> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-    
+  ): Promise<void> {   
     const maxAge = 60 * 60;
     const cookieOpts: CookieSerializeOptions = { httpOnly: true, sameSite: 'lax', path: '/', maxAge };
     const expiration = Math.floor(Date.now() / 1000 + maxAge);
@@ -31,11 +25,6 @@ export class CookieTransactionStore<TStoreOptions> extends AbstractTransactionSt
   }
 
   async get(identifier: string, options?: TStoreOptions): Promise<TransactionData | undefined> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-
     const cookieValue = this.#cookieHandler.getCookie(identifier, options);
 
     if (cookieValue) {
@@ -44,11 +33,6 @@ export class CookieTransactionStore<TStoreOptions> extends AbstractTransactionSt
   }
 
   async delete(identifier: string, options?: TStoreOptions | undefined): Promise<void> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-
     this.#cookieHandler.deleteCookie(identifier, options);
   }
 }

packages/auth0-server-js/src/store/stateful-state-store.ts

@@ -1,4 +1,3 @@
-import { MissingStoreOptionsError } from '../errors.js';
 import type {
   EncryptedStoreOptions,
   LogoutTokenClaims,
@@ -44,11 +43,6 @@ export class StatefulStateStore<TStoreOptions> extends AbstractSessionStore<TSto
     removeIfExists?: boolean,
     options?: TStoreOptions | undefined
   ): Promise<void> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-
     let sessionId = await this.getSessionId(identifier, options);
 
     // if this is a new session created by a new login we need to remove the old session
@@ -83,11 +77,6 @@ export class StatefulStateStore<TStoreOptions> extends AbstractSessionStore<TSto
   }
 
   async get(identifier: string, options?: TStoreOptions | undefined): Promise<StateData | undefined> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-
     const sessionId = await this.getSessionId(identifier, options);
 
     if (sessionId) {
@@ -103,11 +92,6 @@ export class StatefulStateStore<TStoreOptions> extends AbstractSessionStore<TSto
   }
 
   async delete(identifier: string, options?: TStoreOptions | undefined): Promise<void> {
-    // We can not handle cookies when the `StoreOptions` are not provided.
-    if (!options) {
-      throw new MissingStoreOptionsError();
-    }
-
     const sessionId = await this.getSessionId(identifier, options);
 
     if (sessionId) {
@@ -117,7 +101,7 @@ export class StatefulStateStore<TStoreOptions> extends AbstractSessionStore<TSto
     this.#cookieHandler.deleteCookie(identifier, options);
   }
 
-  private async getSessionId(identifier: string, options: TStoreOptions) {
+  private async getSessionId(identifier: string, options?: TStoreOptions) {
     const cookieValue = this.#cookieHandler.getCookie(identifier, options);
     if (cookieValue) {
       const sessionCookie = await this.decrypt<{ id: string }>(identifier, cookieValue);

packages/auth0-server-js/src/store/stateless-state-store.ts

@@ -1,4 +1,3 @@
-import { MissingStoreOptionsError } from 'src/errors.js';
 import type { EncryptedStoreOptions, StateData } from './../types.js';
 import { AbstractSessionStore } from './abstract-session-store.js';
 import type { CookieHandler, CookieSerializeOptions } from './cookie-handler.js';