Use == instead of EXPECT_EQ in testlib (facebook#1740)

avp · facebook-github-bot · commit beee017402f2 · 2025-07-23T16:09:45.000-07:00
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
diff --git a/API/jsi/jsi/test/testlib.cpp b/API/jsi/jsi/test/testlib.cpp
@@ -1877,7 +1877,7 @@ TEST_P(JSITest, CastInterface) {
   auto randomUuid = UUID{0xf2cd96cf, 0x455e, 0x42d9, 0x850a, 0x13e2cde59b8b};
   auto ptr = rd.castInterface(randomUuid);
 
-  EXPECT_EQ(ptr, nullptr);
+  EXPECT_TRUE(ptr == nullptr);
 }
 
 INSTANTIATE_TEST_CASE_P(

Original file line number	Diff line number	Diff line change
`@@ -1877,7 +1877,7 @@ TEST_P(JSITest, CastInterface) {`
`1877`	`1877`	`auto randomUuid = UUID{0xf2cd96cf, 0x455e, 0x42d9, 0x850a, 0x13e2cde59b8b};`
`1878`	`1878`	`auto ptr = rd.castInterface(randomUuid);`
`1879`	`1879`
`1880`		`- EXPECT_EQ(ptr, nullptr);`
	`1880`	`+ EXPECT_TRUE(ptr == nullptr);`
`1881`	`1881`	`}`
`1882`	`1882`
`1883`	`1883`	`INSTANTIATE_TEST_CASE_P(`