No max-stale = allow anything. Fixes issue #7

Author: aw

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.15 (2015-04-29)
+
+  * No max-stale = allow anything. Fixes issue #7
+
 ## 0.1.14 (2015-04-28)
 
   * Ensure Cache-Control is verified

cache_rules.gemspec

@@ -6,7 +6,7 @@ require 'date'
 
 Gem::Specification.new do |s|
   s.name        = 'cache_rules'
-  s.version     = '0.1.14'
+  s.version     = '0.1.15'
 
   s.date        = Date.today.to_s
 

lib/helpers.rb

@@ -303,10 +303,12 @@ def helper_heuristic(now, cached, current_age)
 
   # source: https://tools.ietf.org/html/rfc7234#section-5.2.1.2
   def helper_max_stale
-    Proc.new {|request, freshness_lifetime, current_age|
+    ->(request, freshness_lifetime, current_age) {
       if request && request['max-stale']
         token = request['max-stale']['token']
         token ? (freshness_lifetime.to_i + token.to_i) > current_age : true
+      else
+        true
       end
     }
   end

test/test_cache_rules.rb

@@ -75,7 +75,7 @@ def test_validate_column3
   end
 
   def test_validate_column4
-    request = {"Host"=>"test.url", "Cache-Control"=>"max-stale=10000000"}
+    request = {"Host"=>"test.url"}
     cached  = {"Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "X-Cache-Req-Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "X-Cache-Res-Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "Last-Modified" => {"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "Last-Modified" => {"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "ETag" => "\"validEtag\"", "Cache-Control"=>{"max-age"=>{"token"=>"100", "quoted_string" => nil}}} 
 
     result = CacheRules.validate('http://test.url/test1', request, cached)
@@ -87,7 +87,7 @@ def test_validate_column4
   end
 
   def test_validate_column5
-    request = {"Host"=>"test.url", "Cache-Control"=>"max-stale=10000000", "If-None-Match"=>"*"}
+    request = {"Host"=>"test.url", "If-None-Match"=>"*"}
     cached  = {"Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "X-Cache-Req-Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "X-Cache-Res-Date"=>{"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "Last-Modified" => {"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "Last-Modified" => {"httpdate"=>"Sat, 03 Jan 2015 07:03:45 GMT", "timestamp"=>1420268625}, "ETag" => "\"validEtag\"", "Cache-Control"=>{"max-age"=>{"token"=>"100", "quoted_string" => nil}}} 
 
     result = CacheRules.validate('http://test.url/test1', request, cached)

test/test_helpers.rb

@@ -376,7 +376,7 @@ def test_max_stale
 
     assert_kind_of TrueClass, stale
     assert_kind_of FalseClass, fresh
-    assert_nil noop
+    assert_kind_of TrueClass, noop
     assert_kind_of TrueClass, notoken
   end
 

test/test_regressions.rb

@@ -26,4 +26,13 @@ def test_bugfix_5_age_header_string_integer
     assert_kind_of String,  age_string['Age']
     assert_kind_of Integer, age_integer
   end
+
+  # https://github.com/aw/CacheRules/issues/7
+  def test_bugfix_7_invalid_validation_of_max_stale
+    request = {"Host"=>"test.url"}
+
+    no_max_stale = CacheRules.helper_max_stale.call request, 0, 0
+
+    assert_kind_of TrueClass, no_max_stale
+  end
 end