ASG schedules not being created on ASG Creation, only on subsequent tag creation or update

[mdgm88]

Describe the bug

Creating AWS::AutoScaling::AutoScalingGroup CloudFormation resource with the appropriate Tag should trigger scheduling of ASG

Schedules are currently only created if the tag is subsequently created/updated after ASG creation.

To Reproduce

Create CFN template with AWS::AutoScaling::AutoScalingGroup resource with tag key/value pair indicating that ASG is to be scheduled
Schedules is not created for ASG

Expected behavior

Schedule is created when an ASG is created with the appropriate Tag Key/Value pair.

Please complete the following information about the solution:

• Version: 3.1.0

[mdgm88]

The ResourceRegistrationAsgTaggi event rule is checking for "CreateOrUpdateTags" and "DeleteTags" events, but when the resource is created using CloudFormation with tags on creation the event is a "CreateAutoScalingGroup" event

[mdgm88]

It looks like fixing this should be a simple fix.

Updating

instance-scheduler-on-aws/source/app/instance_scheduler/handler/create_region_event_rules_handler.py

Line 127 in cde5670

"eventName": ["CreateOrUpdateTags", "DeleteTags"],

and

instance-scheduler-on-aws/source/instance-scheduler/lib/lambda-functions/resource-registration.ts

Line 61 in cde5670

eventName: ["CreateOrUpdateTags", "DeleteTags"],

to add "CreateAutoScalingGroup" as an additional eventName should fix this. I manually updated the event rules to add this, then created another autoscaling group in CloudFormation with tagging on creation and with this event added to the ASG tagging event rules it registered successfully.

If tags are added as part of Creating an Autoscaling Group there is not a separate CloudTrail event to CreateOrUpdateTags, it's part of the CreateAutoScalingGroup event.

[gockle]

Hi @mdgm88
Thanks for the providing the detailed description of the issue, we will review this and provide an update here.