Skip to content

Commit dd3c556

Browse files
authored
fix: Making integration tests work on Windows (#494)
1 parent f88bbd3 commit dd3c556

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ instance/
283283
docs/_build/
284284

285285
# PyBuilder
286-
target/
286+
/target/
287287

288288
# Jupyter Notebook
289289
.ipynb_checkpoints

tests/integration/local/invoke/runtimes/test_with_runtime_zips.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,16 @@ def setUp(self):
1313

1414
self.template_path = os.path.join(self.test_data_path, "invoke", "runtimes", "template.yaml")
1515

16-
self.events_file = tempfile.NamedTemporaryFile()
17-
self.events_file.write('"yolo"') # Just empty event
18-
self.events_file.flush()
16+
# Don't delete on close. Need the file to be present for tests to run.
17+
events_file = tempfile.NamedTemporaryFile(delete=False)
18+
events_file.write(b'"yolo"') # Just empty event
19+
events_file.flush()
20+
events_file.close()
1921

20-
self.events_file_path = self.events_file.name
22+
self.events_file_path = events_file.name
2123

2224
def tearDown(self):
23-
self.events_file.close()
25+
os.remove(self.events_file_path)
2426

2527
@parameterized.expand([
2628
param("Go1xFunction"),
Binary file not shown.

0 commit comments

Comments
 (0)