updates to upload/download

Author: narahavi

src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadHandle.h

@@ -21,6 +21,8 @@ class AWS_S3_TRANSFER_API DownloadHandle final {
 public:
   explicit DownloadHandle(Aws::UniquePtr<DownloadHandleImpl> impl);
   ~DownloadHandle();
+  DownloadHandle(const DownloadHandle&) = delete;
+  DownloadHandle& operator=(const DownloadHandle&) = delete;
   DownloadHandle(DownloadHandle&&) noexcept;
   DownloadHandle& operator=(DownloadHandle&&) noexcept;
 

src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/S3TransferManagerConfiguration.h

@@ -15,8 +15,8 @@ namespace Aws {
 namespace S3 {
 namespace Transfer {
 
-constexpr uint64_t SEP_DEFAULT_PART_SIZE_BYTES = 8ULL * 1024 * 1024;
-constexpr uint64_t SEP_DEFAULT_MULTIPART_UPLOAD_THRESHOLD_BYTES = 16ULL * 1024 * 1024;
+constexpr uint64_t DEFAULT_PART_SIZE_BYTES = 8ULL * 1024 * 1024;
+constexpr uint64_t DEFAULT_MULTIPART_UPLOAD_THRESHOLD_BYTES = 16ULL * 1024 * 1024;
 
 struct AWS_S3_TRANSFER_API S3TransferManagerConfiguration final : public Aws::Client::GenericClientConfiguration {
   using BaseClientConfigClass = Aws::Client::GenericClientConfiguration;
@@ -26,9 +26,9 @@ struct AWS_S3_TRANSFER_API S3TransferManagerConfiguration final : public Aws::Cl
   explicit S3TransferManagerConfiguration(bool useSmartDefaults, const char* defaultMode = "legacy", bool shouldDisableIMDS = false);
   S3TransferManagerConfiguration(const Aws::Client::ClientConfiguration& config);
 
-  uint64_t partSize = SEP_DEFAULT_PART_SIZE_BYTES;
+  uint64_t partSize = DEFAULT_PART_SIZE_BYTES;
   // Object size at or above which a multipart transfer is used. Must be >= partSize.
-  uint64_t multipartUploadThreshold = SEP_DEFAULT_MULTIPART_UPLOAD_THRESHOLD_BYTES;
+  uint64_t multipartUploadThreshold = DEFAULT_MULTIPART_UPLOAD_THRESHOLD_BYTES;
   // 0 means inherit the CRT's own default.
   double throughputTargetGbps = 0.0;
   Aws::Crt::Optional<Aws::Crt::Io::TlsConnectionOptions> tlsConnectionOptions;

src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/UploadHandle.h

@@ -21,6 +21,8 @@ class AWS_S3_TRANSFER_API UploadHandle final {
 public:
   explicit UploadHandle(Aws::UniquePtr<UploadHandleImpl> impl);
   ~UploadHandle();
+  UploadHandle(const UploadHandle&) = delete;
+  UploadHandle& operator=(const UploadHandle&) = delete;
   UploadHandle(UploadHandle&&) noexcept;
   UploadHandle& operator=(UploadHandle&&) noexcept;
 

src/aws-cpp-sdk-s3-transfer/source/s3-transfer/internal/CrtOperations.cpp

@@ -238,7 +238,7 @@ bool TryMeasureSeekableStream(Aws::IOStream& stream, uint64_t& outLength) {
 void RunAsyncWriteDriver(std::shared_ptr<UploadTransferState> state,
                         std::shared_ptr<Aws::Crt::S3::S3MetaRequest> metaRequest,
                         std::shared_ptr<Aws::IOStream> body) {
-  Aws::Utils::Array<uint8_t> buffer(static_cast<size_t>(SEP_DEFAULT_PART_SIZE_BYTES));
+  Aws::Utils::Array<uint8_t> buffer(static_cast<size_t>(DEFAULT_PART_SIZE_BYTES));
   bool eof = false;
   while (!eof) {
     if (state->canceled.load()) {

src/aws-cpp-sdk-s3-transfer/source/s3-transfer/internal/S3TransferManagerImpl.cpp

@@ -30,10 +30,8 @@ S3TransferManagerImpl::S3TransferManagerImpl(const S3TransferManagerConfiguratio
   Aws::Crt::S3::S3ClientConfig clientConfig(m_credentialsProvider);
   clientConfig.SetRegion(Aws::Crt::String(m_region.c_str()))
       .SetPartSize(config.partSize)
-      .SetMultipartUploadThreshold(config.multipartUploadThreshold);
-  if (config.throughputTargetGbps > 0.0) {
-    clientConfig.SetThroughputTargetGbps(config.throughputTargetGbps);
-  }
+      .SetMultipartUploadThreshold(config.multipartUploadThreshold)
+      .SetThroughputTargetGbps(config.throughputTargetGbps);
   if (config.tlsConnectionOptions) {
     clientConfig.SetTlsConnectionOptions(*config.tlsConnectionOptions);
   }