Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Advanced variable injection #6

Description

@mattsb42-aws

If environment variable values being injected contain special characters, notably any of ", ', \, and probably more, shlex gets very confused when we attempt to split the command after injection.

The current flow is:

  1. Inject values
  2. shlex.split
  3. shlex.quote

I think that the correct approach here might simply be to:

  1. shlex.split (keeping Add Windows testing and validate command processing #5 in mind)
  2. Inject values in each split command
  3. shlex.quote

Metadata

Metadata

Assignees

No one assigned

    Labels

    blocks next releaseThis issue must be fixed before the next release

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions