In spring-cloud-aws-s3/pom.xml, the com.fasterxml.jackson.core:jackson-databind dependency is not marked as <optional>true</optional>, unlike every other module:
| Module |
com.fasterxml jackson-databind optional? |
| spring-cloud-aws-sqs |
Yes |
| spring-cloud-aws-sns |
Yes |
| spring-cloud-aws-secrets-manager |
Yes |
| spring-cloud-aws-s3 |
No |
The tools.jackson.core:jackson-databind entry added in #1539 is correctly marked optional. It looks like the existing com.fasterxml entry was missed during that change.
This causes com.fasterxml.jackson.core:jackson-databind (and its transitives jackson-core, jackson-annotations) to leak onto the runtime classpath of any project that depends on spring-cloud-aws-starter-s3, even if the project only uses Jackson 3.
Should this be marked <optional>true</optional> to match the other modules?
In
spring-cloud-aws-s3/pom.xml, thecom.fasterxml.jackson.core:jackson-databinddependency is not marked as<optional>true</optional>, unlike every other module:com.fasterxmljackson-databind optional?The
tools.jackson.core:jackson-databindentry added in #1539 is correctly marked optional. It looks like the existingcom.fasterxmlentry was missed during that change.This causes
com.fasterxml.jackson.core:jackson-databind(and its transitivesjackson-core,jackson-annotations) to leak onto the runtime classpath of any project that depends onspring-cloud-aws-starter-s3, even if the project only uses Jackson 3.Should this be marked
<optional>true</optional>to match the other modules?