tokens: treat wrapped 404 errors as missing resources

Amp-Thread-ID: https://ampcode.com/threads/T-019cb11d-d0b4-724b-938e-a9eb7f44c002
Co-authored-by: Amp <amp@ampcode.com>

Author: toppercodes

axiom/utils.go

@@ -160,9 +160,20 @@ func convertAttribute(resourceAttribute resourceschema.Attribute) datasourcesche
 }
 
 func isNotFoundError(err error) bool {
+	if errors.Is(err, axiom.ErrNotFound) {
+		return true
+	}
+
+	// Keep backward compatibility for callers that may wrap concrete HTTPError values.
 	var apiError axiom.HTTPError
 	if errors.As(err, &apiError) {
 		return apiError.Status == 404
 	}
+
+	var apiErrorPtr *axiom.HTTPError
+	if errors.As(err, &apiErrorPtr) && apiErrorPtr != nil {
+		return apiErrorPtr.Status == 404
+	}
+
 	return false
 }

axiom/utils_test.go

@@ -0,0 +1,52 @@
+package axiom
+
+import (
+	"errors"
+	"fmt"
+	"testing"
+
+	ax "github.com/axiomhq/axiom-go/axiom"
+)
+
+func TestIsNotFoundError(t *testing.T) {
+	tests := []struct {
+		name string
+		err  error
+		want bool
+	}{
+		{
+			name: "axiom ErrNotFound",
+			err:  ax.ErrNotFound,
+			want: true,
+		},
+		{
+			name: "wrapped value HTTPError 404",
+			err:  fmt.Errorf("wrapped: %w", ax.HTTPError{Status: 404, Message: "Not Found"}),
+			want: true,
+		},
+		{
+			name: "wrapped pointer HTTPError 404",
+			err:  fmt.Errorf("wrapped: %w", &ax.HTTPError{Status: 404, Message: "Not Found"}),
+			want: true,
+		},
+		{
+			name: "other status",
+			err:  ax.HTTPError{Status: 500, Message: "Internal Server Error"},
+			want: false,
+		},
+		{
+			name: "generic error",
+			err:  errors.New("boom"),
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := isNotFoundError(tt.err)
+			if got != tt.want {
+				t.Fatalf("isNotFoundError() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}