You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(review): accept positional focus text for parity with adversarial-review
Closesopenai#522.
`/codex:review` unconditionally rejected any positional argument as
"custom focus text" (validateNativeReviewRequest), while
`/codex:adversarial-review` accepts it. That interface-parity gap also
blocked non-English model/effort entry: even when a host (e.g. Claude)
rewrites a natural-language phrase into `--model`/`--effort`, any
residual positional word still aborted the native review.
Remove the unconditional focus-text rejection. The native reviewer
(review/start) does not consume focus text, so leftover positional words
are now silently ignored rather than rejecting the invocation. Review
semantics are unchanged (still native structured-review); only the
spurious abort is gone.
Companion does no language/alias recognition — that is the host/.md
layer's job. This fix is purely about parity: review no longer fails
where adversarial-review succeeds.
Tested: runtime parity test (red before, green after), commands.test.mjs
assert updated to the new review.md wording. 0 regressions vs the openai#471
base (4 pre-existing fails unchanged).
Co-Authored-By: Claude <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: plugins/codex/commands/review.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -36,7 +36,7 @@ Argument handling:
36
36
-`--model` and `--effort` select the Codex runtime for the review and are not focus text.
37
37
- Do not strip `--wait` or `--background` yourself.
38
38
- The companion script parses `--wait` and `--background`, but Claude Code's `Bash(..., run_in_background: true)` is what actually detaches the run.
39
-
-`/codex:review` is native-review only. It does not support staged-only review, unstaged-only review, or extra focus text.
39
+
-`/codex:review` is native-review only. It does not support staged-only review or unstaged-only review. Positional focus text is ignored by the native reviewer (for interface parity with `/codex:adversarial-review`); it does not abort the review.
40
40
- If the user needs custom review instructions or more adversarial framing, they should use `/codex:adversarial-review`.
`\`/codex:review\` now maps directly to the built-in reviewer and does not support custom focus text. Retry with \`/codex:adversarial-review ${focusText.trim()}\` for focused review instructions.`
0 commit comments