Commit 2c0b1f1
committed
[Bug] planning_enabled permanently strips the director's SwarmSpec schema
HierarchicalSwarm.run_director and the async streaming loop both set
self.director.tools_list_dictionary = None before running the planning
sub-step.
That assignment cannot do what it looks like it does.
setup_director_with_planning builds its own throwaway Agent and already
excludes base_model and tools_list_dictionary from the settings it
forwards, so planning has always run schema-free without any help. The
line only reaches the real director -- the one the swarm depends on for
structured SwarmSpec output on the very next call, and the one the
caller may own when a director is passed in explicitly.
Delete both assignments. Add a test that pins the director's schema
across a planning-enabled run_director.1 parent fd9c2e0 commit 2c0b1f1
2 files changed
Lines changed: 36 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
762 | 762 | | |
763 | 763 | | |
764 | 764 | | |
765 | | - | |
766 | 765 | | |
767 | 766 | | |
768 | 767 | | |
| |||
2000 | 1999 | | |
2001 | 2000 | | |
2002 | 2001 | | |
2003 | | - | |
2004 | 2002 | | |
2005 | 2003 | | |
2006 | 2004 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1056 | 1056 | | |
1057 | 1057 | | |
1058 | 1058 | | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
1059 | 1095 | | |
1060 | 1096 | | |
0 commit comments