Skip to content

[upstream #4505] fix(cli): Exclude translatable fields from top-level input type | #4373 - #39

Open
ayim wants to merge 5 commits into
masterfrom
mirror/upstream-4505
Open

[upstream #4505] fix(cli): Exclude translatable fields from top-level input type | #4373#39
ayim wants to merge 5 commits into
masterfrom
mirror/upstream-4505

Conversation

@ayim

@ayim ayim commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Mirrored from vendurehq#4505 for the Overwatch review demo.

Original author: @SupunGeethanjana


Description

Please include a summary of the changes and the related issue.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@ayim

ayim commented Jul 28, 2026

Copy link
Copy Markdown
Owner Author

@codex

overwatch-pr[bot]

This comment was marked as outdated.

Repository owner deleted a comment from chatgpt-codex-connector Bot Jul 28, 2026
@overwatch-pr

overwatch-pr Bot commented Jul 28, 2026

Copy link
Copy Markdown

Overwatch assessment: AUTO-APPROVE

Reviewed commit: cca64b415dd8a568fa53b3b8911a8f27d3eb3cf8
Confidence: 97%
Decision: Approved with a one-hour intervention hold

This is a contained generator fix with no deployed runtime or customer-flow exposure. The upstream implementation has already received human approval.

Evidence by dimension

Dimension Finding Decision impact
Change surface 1 file, 12 added lines in packages/cli/src/commands/add/api-extension/add-api-extension.ts. The change skips translatable fields when generating top-level API input types. Low risk — contained to CLI scaffolding; no service or schema migration is executed by this diff.
Human review history Upstream reviewer grolmus confirmed the fix is correct and submitted an APPROVED review. No human reviewer requested changes. Supports approval — domain reasoning was independently validated.
Related implementation history The change addresses issue #4373: LocaleString fields were appearing in both top-level Create/Update inputs and TranslationInput. No prior risky implementation or conflicting reviewer guidance was found on this file. Low uncertainty — behavior and intended correction are explicit.
Runtime and incidents No deployed service, New Relic route, or production incident is connected to this CLI-only generator path. No runtime blast radius — the change cannot affect a live request until a developer deliberately runs the generator and adopts its output.
User-flow impact No PostHog storefront, checkout, authentication, or revenue flow maps to this file. No direct customer exposure.

Approval boundary

  • This approval applies only to commit cca64b415dd8a568fa53b3b8911a8f27d3eb3cf8.
  • A new commit must trigger a fresh Overwatch decision.
  • Repository checks remain independent of the code-risk decision; any required failing check must still be resolved before merge.

Overwatch approved because the change is contained, upstream human review supports it, and repository/runtime context shows no production blast radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants