Skip to content

Task 4: Get familiar with C++ #3

Description

@ayushjariyal

based on the List of checks
and that we want to follow more of the cppcoreguidelines

  • Create a working branch on your pgRouting fork departing from develop branch
    • Note: you might need to fetch/pull/merge/rebase upstream to catch changes done on the pgRouting repository
  • Enable actions on your fork
    • Do not use a branch that is going to be on a PR to do this task
  • Modify .clang-tidy
    • add a new cppcoreguidelines
    • if it does not generate warning/errors
      • Commit and make a PR to develop branch of pgRouting repository
    • Repeat the above until you find one that generate warnings/errors
    • Fix the errors/warnings
    • Commit and make a PR to develop branch of pgRouting
      • The initial PR message must be written by you

Note about commits:

  • Use a meaningful commit message to the project
    • do not use: task4 ..... that is meaningful for the application but not for the project,
    • Something like: clang-tidy: check and fix cppcoreguidelines-avoid-reference-coroutine-parameters
  • Do a commit amend if there is a need to change the commit message and force the push
  • It is a commit per cppcoreguidelines that is added/fixed

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions