You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
change deprecated badge messages to 'retired badge'
- reduce confusion over deprecated badge source (badge, shields, endpoint service, user's service)
- reduce length of message to reduce traffic
update all deprecated services and base class code in a follow-up commit after discussion.
see #11792 (comment)
Copy file name to clipboardExpand all lines: doc/deprecating-badges.md
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -46,18 +46,18 @@ export const t = new ServiceTester({
46
46
})
47
47
```
48
48
49
-
Next you will need to replace/refactor the existing tests to validate the new deprecated badge behavior for this service. Deprecated badges always return a message of `no longer available` (such as `imagelayers | no longer available`) so the tests need to be updated to reflect that message value. For example:
49
+
Next you will need to replace/refactor the existing tests to validate the new deprecated badge behavior for this service. Deprecated badges always return a message of `retired badge` (such as `imagelayers | retired badge`) so the tests need to be updated to reflect that message value. For example:
50
50
51
51
```js
52
-
t.create('no longer available (previously image size)')
52
+
t.create('retired badge (previously image size)')
53
53
.get('/image-size/_/ubuntu/latest.json')
54
54
.expectBadge({
55
55
label:'imagelayers',
56
-
message:'no longer available',
56
+
message:'retired badge',
57
57
})
58
58
```
59
59
60
-
Make sure to have a live (non-mocked) test for each badge the service provides that validates the each badge returns the `no longer available` message.
60
+
Make sure to have a live (non-mocked) test for each badge the service provides that validates the each badge returns the `retired badge` message.
61
61
62
62
Here is an example of what the final result would look like for a test file:
63
63
@@ -69,18 +69,18 @@ export const t = new ServiceTester({
69
69
title:'ImageLayers',
70
70
})
71
71
72
-
t.create('no longer available (previously image size)')
72
+
t.create('retired badge (previously image size)')
73
73
.get('/image-size/_/ubuntu/latest.json')
74
74
.expectBadge({
75
75
label:'imagelayers',
76
-
message:'no longer available',
76
+
message:'retired badge',
77
77
})
78
78
79
-
t.create('no longer available (previously number of layers)')
79
+
t.create('retired badge (previously number of layers)')
0 commit comments