Skip to content

Commit b0bf851

Browse files
committed
ci(claude): strip preconceived bug list from review prompt
The earlier draft seeded the prompt with three "common traps in this codebase" bullets (rolling-window edge cases, sampler/coordinator coupling, the `except X, Y:` syntax). That biases the reviewer toward confirming claims the prompt author already made rather than reading the actual diff. Drop the sub-list; let section 2 (HA integration correctness) carry the architectural orientation without naming specific failure modes.
1 parent 5d18612 commit b0bf851

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

.github/workflows/claude-code-review.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,7 @@ jobs:
6565
6666
1. Bugs — logic errors, race conditions, off-by-ones,
6767
broken edge cases. If you find one, leave an inline
68-
comment at the specific line. Common traps in this
69-
codebase:
70-
- Rolling-window math: window length, sample
71-
alignment, missed samples after sleep/suspend,
72-
division by zero when max_mhz is 0.
73-
- Sampler / coordinator coupling: sampler runs at
74-
0.5 s, coordinators publish at 1m/5m/15m windows —
75-
verify the publish path doesn't block the sampler
76-
or drop samples while computing aggregates.
77-
- The `except (X, Y):` tuple form vs. the deprecated
78-
Python-2 `except X, Y:` syntax — the second is a
79-
SyntaxError under Python 3 and will hard-fail
80-
module import.
68+
comment at the specific line.
8169
2. HA integration correctness:
8270
- All sysfs reads (`/sys/devices/system/cpu/.../scaling_*`,
8371
`/proc/stat`, EPP/EPB) must NOT happen on the event

0 commit comments

Comments
 (0)