Draft
Conversation
Contributor
Author
This involves the creation of a new ack_watch channel, that adds a
`send_and_wait` function that gets blocked until the receiver accepts
the request. The channel is configured in such a way that if the request
gets dropped (because it got replaced with a new request), then the
`send_and_wait` method returns an error.
The API `POST /v3/device/apps/{uuid}` endpoint will error with a 409
Conflict in case the state got replaced.
This should make it easier for users of the API to know when the
provided state got accepted by the worker or when it won't be processed.
Change-type: minor
pipex
force-pushed
the
ack-channel-for-api-requests
branch
from
4403729 to
ee34b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves the creation of a new ack_watch channel, that adds a
send_and_waitfunction that gets blocked until the receiver accepts the request. The channel is configured in such a way that if the request gets dropped (because it got replaced with a new request), then thesend_and_waitmethod returns an error.The API
POST /v3/device/apps/{uuid}endpoint will error with a 409 Conflict in case the state got replaced.This should make it easier for users of the API to know when the provided state got accepted by the worker or when it won't be processed.
Change-type: minor