[ddwrt] Fix logging and remove MAC wireless client property

- Change 8 non-compliant logger.info calls to logger.debug per openHAB guidelines
  (info should only be used for newly started components or loaded files)
- Remove MAC address from wireless client discovery properties

PR openhab#20505

Assisted-by: Windsurf:SWE-1.6
Signed-off-by: Lee Ballard <ballle98@gmail.com>

Author: ballle98

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/DDWRTDiscoveryService.java

@@ -201,9 +201,6 @@ private void discoverWirelessClients(DDWRTNetwork net) {
 
             final Map<String, Object> props = new java.util.HashMap<>();
             props.put("hostname", client.getHostname());
-            if (!client.getMac().isEmpty()) {
-                props.put("mac", client.getMac());
-            }
 
             final DiscoveryResult result = DiscoveryResultBuilder.create(thingUID).withBridge(bridgeUID)
                     .withLabel(client.getHostname()).withProperties(props).withRepresentationProperty("hostname")

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/api/DDWRTBaseDevice.java

@@ -1844,7 +1844,7 @@ public void reboot() {
                 lastRecoveryAuthAttemptMs = 0;
                 recoveryNetFailures = 0;
                 lastRecoveryNetAttemptMs = 0;
-                logger.info("Recovered SSH session for {}", config.hostname);
+                logger.debug("Recovered SSH session for {}", config.hostname);
                 SshLogFollower follower = logFollower;
                 if (follower != null) {
                     follower.wakeUp();

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/api/DDWRTNetwork.java

@@ -75,7 +75,7 @@ public class DDWRTNetwork {
     /** Hand the entire bridge configuration to the network. */
     public void setConfig(DDWRTNetworkConfiguration netCfg) {
         if (!Objects.equals(this.config, netCfg)) {
-            logger.info("Config changed.");
+            logger.debug("Config changed.");
             this.config = netCfg;
 
             // Clear failure tracking for retry logic
@@ -252,7 +252,7 @@ public void addFailedDeviceConfig(String hostname, DDWRTDeviceConfiguration cfg)
                 DDWRTNetworkConfiguration netCfg = config;
                 int interval = netCfg != null ? netCfg.refreshInterval : cfg.refreshInterval;
                 device.startRefresh(interval);
-                logger.info("Successfully connected to device: {} (MAC: {})", cfg.hostname, device.getMac());
+                logger.debug("Successfully connected to device: {} (MAC: {})", cfg.hostname, device.getMac());
                 return device;
             }
         } catch (Exception e) {
@@ -317,7 +317,7 @@ public void refresh() {
                         DDWRTNetworkConfiguration netCfg = config;
                         int interval = netCfg != null ? netCfg.refreshInterval : cfg.refreshInterval;
                         device.startRefresh(interval);
-                        logger.info("Successfully reconnected to device: {}", hostname);
+                        logger.debug("Successfully reconnected to device: {}", hostname);
                     }
                 } catch (Exception e) {
                     if (isAuthFailure(e)) {

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/api/SshClientManager.java

@@ -86,7 +86,7 @@ private SshClientManager() {
         Path knownHostsPath = getHomeSshDir() != null ? Objects.requireNonNull(getHomeSshDir()).resolve("known_hosts")
                 : Paths.get(ohPrivateKeyDirString, "known_hosts");
         ServerKeyVerifier verifier = new KnownHostsServerKeyVerifier((s, a, k) -> {
-            logger.info("TOFU: auto-accepting host key for {}", a);
+            logger.debug("TOFU: auto-accepting host key for {}", a);
             return true;
         }, knownHostsPath) {
             @Override

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/handler/DDWRTBaseHandler.java

@@ -136,10 +136,10 @@ public final void handleCommand(ChannelUID channelUID, Command command) {
             if (entity != null && network != null) {
                 try {
                     if (!handleCommand(network, entity, channelUID, command)) {
-                        logger.info("Ignoring unsupported command = {} for channel = {}", command, channelUID);
+                        logger.debug("Ignoring unsupported command = {} for channel = {}", command, channelUID);
                     }
                 } catch (Exception e) {
-                    logger.info("Error handling command = {} for channel = {}: {}", command, channelUID,
+                    logger.debug("Error handling command = {} for channel = {}: {}", command, channelUID,
                             e.getMessage());
                 }
             } else {

bundles/org.openhab.binding.ddwrt/src/main/java/org/openhab/binding/ddwrt/internal/handler/DDWRTFirewallRuleHandler.java

@@ -80,7 +80,7 @@ protected boolean handleCommand(DDWRTNetwork network, DDWRTFirewallRule rule, Ch
             Command command) {
         String channelId = channelUID.getIdWithoutGroup();
         if (CHANNEL_ENABLED.equals(channelId) && command instanceof OnOffType) {
-            logger.info("Firewall rule enable/disable not yet implemented for {}", rule.getRuleId());
+            logger.debug("Firewall rule enable/disable not yet implemented for {}", rule.getRuleId());
             return false;
         }
         return false;