ScreenPyHQ#153: remove support for python 3.8, add support for python 3.13. (ScreenPyHQ#158)

* ScreenPyHQ#153: remove support for python 3.8, add support for python 3.13.
* ScreenPyHQ#153: remove Python 3.8 from github actions.
* update poetry github job.
* cruft update for Makefile.
* cruft update for Makefile, again.
* apply cruft updates.
* add Path typing to Narrator and Adapter.
* update dependencies
* add test for Path attachments.

Author: perrygoy

.cruft.json

@@ -1,6 +1,6 @@
 {
   "template": "https://github.com/ScreenPyHQ/cookiecutter_screenpy/",
-  "commit": "96416427ba79a718959084081e3b5d6a8860336a",
+  "commit": "6a7488b4183f615ff319dbfdac38a3a1354953c7",
   "checkout": null,
   "context": {
     "cookiecutter": {
@@ -12,7 +12,7 @@
       "author_email": "perry.goy@gmail.com",
       "github_username": "ScreenPyHQ",
       "_template": "https://github.com/ScreenPyHQ/cookiecutter_screenpy/",
-      "_commit": "96416427ba79a718959084081e3b5d6a8860336a"
+      "_commit": "6a7488b4183f615ff319dbfdac38a3a1354953c7"
     }
   },
   "directory": null

.github/workflows/cruft.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.12"]
+        python-version: ["3.13"]
         os: [ubuntu-latest]
 
     steps:

.github/workflows/lint.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         os: [ubuntu-latest]
 
     steps:

.github/workflows/poetry.yml

@@ -16,9 +16,9 @@ jobs:
       max-parallel: 9
       fail-fast: false
       matrix:
-        python-version: ["3.12"]
+        python-version: ["3.13"]
         os: [ubuntu-latest]
-        poetry-version: ["1.6.1"]
+        poetry-version: ["2.1.3"]
 
     steps:
       - uses: actions/checkout@v4
@@ -32,8 +32,5 @@ jobs:
         with:
           poetry-version: ${{ matrix.poetry-version }}
 
-      - name: Check toml structure
-        run: poetry check
-
-      - name: Check lock file
-        run: poetry lock --check
+      - name: Check lock file is consistent with pyproject
+        run: poetry check --lock

.github/workflows/tests.yml

@@ -16,7 +16,7 @@ jobs:
       max-parallel: 9
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         os: [ubuntu-latest]
 
     steps:

.pre-commit-config.yaml

@@ -30,11 +30,15 @@ mypy:
 
 .PHONY: black-check black-fix ruff-check ruff-fix mypy
 
+lint: black-check ruff-check
+
+lint-fix: black-fix ruff-fix
+
 pre-check-in: black-check ruff-check mypy
 
 pre-check-in-fix: black-fix ruff-fix mypy
 
-.PHONY: pre-check-in pre-check-in-fix
+.PHONY: pre-check-in pre-check-in-fix lint lint-fix
 
 # requires poetry-plugin-export
 requirements:

Makefile

@@ -67,7 +67,6 @@ You want to contribute? Great! Here are the things you should do before submitti
     1. `pip install -e .[dev]`
     1. Optional (poetry users):
         1. `poetry install --extras dev`
-1. Run `pre-commit install` once.
 1. Run `tox` to perform tests frequently.
 1. Create pull-request from your branch.
 

README.md

@@ -19,7 +19,7 @@ build-backend = "poetry.core.masonry.api"
 
 
 [tool.black]
-target-version = ['py312']
+target-version = ['py313']
 extend-exclude = '''
 # A regex preceded with ^/ will apply only to files and directories
 # in the root of the project.
@@ -36,7 +36,7 @@ extend-exclude = '''
 
 
 [tool.ruff]
-target-version = "py38"  # minimum supported version
+target-version = "py39"  # minimum supported version
 line-length = 88  # same as Black.
 output-format = "concise"
 extend-exclude = [
@@ -45,57 +45,25 @@ extend-exclude = [
 
 [tool.ruff.lint]
 select = [
-    "A",  # flake8-builtins
-    "ANN",  # flake8-annotations
-    "ARG",  # flake8-unused-arguments
-    "B",  # flake8-bugbear
-    "BLE",  # flake8-blind-except
-    "C4",  # flake8-comprehensions
-    "D",  # pydocstyle
-    "E",  # pycodestyle error
-    "EM",  # flake8-errmsg
-    "ERA",  # eradicate
-    "F",  # Pyflakes
-    "FA",  # flake8-future-annotations
-    "FBT",  # flake8-boolean-trap
-    "FIX",  # flake8-fixme
-    "FLY",  # flynt
-    "I",  # isort
-    "ICN",  # flake8-import-conventions
-    "ISC",  # flake8-implicit-str-concat
-    "PGH",  # pygrep-hooks
-    "PIE",  # flake8-pie
-    "PL",  # pylint
-    "PT",  # flake8-pytest-style
-    "Q",  # flake8-quotes
-    "RET",  # flake8-return
-    "RSE",  # flake8-raise
-    "RUF",  # ruff specific
-    "SIM",  # flake8-simplify
-    "T10",  # flake8-debugger
-    "T20",  # flake8-print
-    "TCH",  # flake8-type-checking
-    "TRY",  # tryceratops
-    "UP",  # python upgrade
-    "W",  # pycodestyle warning
-    "YTT",  # flake8-2020
-
-    # we would like these someday, but not yet
-    # "FURB",  # refurb
+    "ALL",  # let's get all the new hotness and ignore as we need!
 ]
 ignore = [
-    "D107",  # missing __init__ docstring, we do that in the class docstring.
-    "D203",  # one blank line before class docstring, no thanks!
-    "D212",  # multi line summary first line, we want a one line summary.
+    "COM812",  # we prefer black's logic for trailing commas
+    "D107",    # missing __init__ docstring, we do that in the class docstring.
+    "D203",    # one blank line before class docstring, no thanks!
+    "D212",    # multi line summary first line, we want a one line summary.
+    "E501",    # black handles our line limits.
+    "N818",    # we like our conventions with readable error classes.
+    "S608",    # we will not have SQL injection concerns. :P
 ]
 
 extend-safe-fixes = [
-    "EM101", "EM102",
-    "TCH001", "TCH002", "TCH003", "TCH004",
     "C419",
     "D200", "D205", "D415",
+    "EM101", "EM102",
     "PT003", "PT006", "PT018",
     "RET504",
+    "TCH001", "TCH002", "TCH003", "TCH004",
     "UP006", "UP007",
     "W291",
 ]
@@ -118,12 +86,20 @@ split-on-trailing-comma = false
 
 [tool.ruff.lint.per-file-ignores]
 "tests/**" = [
-    "D",  # we don't need public-API-polished docstrings in tests.
-    "FBT",  # using a boolean as a test object is useful!
-    "PLR",  # likewise using specific numbers and strings in tests.
-    "A",    # import __doc__ is shadowing python builtin
+   "A",       # import __doc__ is shadowing python builtin
+   "D",       # we don't need public-API-polished docstrings in tests.
+   "FBT",     # using a boolean as a test object is useful!
+   "N802",    # we are intentional about our capitalization!
+   "N803",    # we like our standards for variable names in tests.
+   "N806",    # we are intentional about our capitalization!
+   "PLR",     # using specific numbers and strings in tests is useful!
+   "PYI034",  # our Fake-ables need to be... weird.
+   "S101",    # we want to assert in tests!
+   "SLF001",  # we need to access private methods in tests.
+]
+"__version__.py" = [
+    "D",  # we don't need public-API-polished docstrings in version.
 ]
-"__version__.py" = ["D"]
 
 
 ################################################################################
@@ -149,11 +125,11 @@ readme = "README.md"
 classifiers = [
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3 :: Only",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
     "Development Status :: 5 - Production/Stable",
     "Intended Audience :: Developers",
     "Topic :: Software Development :: Quality Assurance",
@@ -172,9 +148,9 @@ classifiers = [
 # so we dont have two different sets of package versions to update.
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 
-importlib_metadata = {version = "*", python = "3.8.*"}
+importlib_metadata = {version = "*", python = "3.9.*"}
 pydantic = "*"
 pydantic-settings = "*"
 PyHamcrest = ">=2.0.0"