forgot we talked about removing the protocol earlier this summer.

Author: bandophahita

screenpy/actions/silently.py

@@ -49,7 +49,6 @@ def Silently(duck: T) -> T:
         )
     """
     if settings.UNABRIDGED_NARRATION:
-        duck._silenced = False  # type: ignore[attr-defined]
         return duck
 
     # mypy really doesn't like monkeypatching

screenpy/protocols.py

@@ -134,10 +134,3 @@ def attach(self, filepath: str, **kwargs: Any) -> None:  # noqa: ANN401
 
         Pass keyword arguments for specific adapters' needs.
         """
-
-
-@runtime_checkable
-class Silenceable(Protocol):
-    """Classes wrapped in Silently are Silenceable."""
-
-    _silenced: bool

screenpy/speech_tools.py

@@ -8,13 +8,7 @@
 
 from hamcrest.core.helpers.hasmethod import hasmethod
 
-from screenpy.protocols import (
-    Answerable,
-    Describable,
-    Performable,
-    Resolvable,
-    Silenceable,
-)
+from screenpy.protocols import Answerable, Describable, Performable, Resolvable
 
 T = TypeVar("T")
 
@@ -83,6 +77,4 @@ def represent_prop(item: str | T | mock.Mock) -> str | mock.Mock:
 
 def is_silent(duck: Performable | Resolvable | Answerable) -> bool:
     """Check if a duck has been silenced."""
-    if isinstance(duck, Silenceable):
-        return duck._silenced
-    return False
+    return getattr(duck, "_silenced", False)

tests/test_actions.py

@@ -35,7 +35,6 @@
     the_narrator,
 )
 from screenpy.configuration import ScreenPySettings
-from screenpy.protocols import Silenceable
 from screenpy.speech_tools import is_silent
 
 from .unittest_protocols import ErrorQuestion
@@ -863,13 +862,6 @@ def test_implements_protocol(self) -> None:
         assert isinstance(q1, Describable)
         assert isinstance(q2, Describable)
         assert isinstance(q3, Describable)
-        assert isinstance(q1, Silenceable)
-        assert isinstance(q2, Silenceable)
-        assert isinstance(q3, Silenceable)
-
-        assert not isinstance(FakeQuestion(), Silenceable)
-        assert not isinstance(FakeAction(), Silenceable)
-        assert not isinstance(FakeResolution(), Silenceable)
 
     def test_passthru_attribute(self) -> None:
         a = FakeAction()
@@ -946,15 +938,12 @@ def test_sets_silenced_attribute_false(self) -> None:
             q2 = Silently(FakeAction())
             q3 = Silently(FakeResolution())
 
-        assert q1._silenced is False
-        assert q2._silenced is False
-        assert q3._silenced is False
+        assert not hasattr(q1, "_silenced")
+        assert not hasattr(q2, "_silenced")
+        assert not hasattr(q3, "_silenced")
         assert is_silent(q1) is False
         assert is_silent(q2) is False
         assert is_silent(q3) is False
-        assert isinstance(q1, Silenceable)
-        assert isinstance(q2, Silenceable)
-        assert isinstance(q3, Silenceable)
 
     def test_sets_silenced_attribute_true(self) -> None:
         mock_settings = ScreenPySettings(UNABRIDGED_NARRATION=False)
@@ -969,9 +958,6 @@ def test_sets_silenced_attribute_true(self) -> None:
         assert is_silent(q1) is True
         assert is_silent(q2) is True
         assert is_silent(q3) is True
-        assert isinstance(q1, Silenceable)
-        assert isinstance(q2, Silenceable)
-        assert isinstance(q3, Silenceable)
 
     def test_kinking(self, Tester: Actor, mocker: MockerFixture) -> None:
         mock_clear = mocker.spy(the_narrator, "clear_backup")