Address webhook review feedback

Author: robzolkos

internal/commands/webhook.go

@@ -268,7 +268,7 @@ var webhookCreateCmd = &cobra.Command{
 			SubscribedActions: webhookCreateActions,
 		}
 
-		raw, _, err := ac.Webhooks().Create(cmd.Context(), boardID, req)
+		raw, resp, err := ac.Webhooks().Create(cmd.Context(), boardID, req)
 		if err != nil {
 			return convertSDKError(err)
 		}
@@ -287,7 +287,11 @@ var webhookCreateCmd = &cobra.Command{
 			}
 		}
 
-		printMutation(data, "", breadcrumbs)
+		if location := resp.Headers.Get("Location"); location != "" {
+			printMutationWithLocation(data, location, breadcrumbs)
+		} else {
+			printMutation(data, "", breadcrumbs)
+		}
 		return nil
 	},
 }
@@ -394,16 +398,22 @@ var webhookReactivateCmd = &cobra.Command{
 		webhookID := args[0]
 
 		ac := getSDK()
-		if _, err := ac.Webhooks().Activate(cmd.Context(), boardID, webhookID); err != nil {
+		resp, err := ac.Webhooks().Activate(cmd.Context(), boardID, webhookID)
+		if err != nil {
 			return convertSDKError(err)
 		}
 
+		data := normalizeAny(resp.Data)
+		if data == nil {
+			data = map[string]any{"id": webhookID, "active": true}
+		}
+
 		breadcrumbs := []Breadcrumb{
 			breadcrumb("show", fmt.Sprintf("fizzy webhook show --board %s %s", boardID, webhookID), "View webhook"),
 			breadcrumb("webhooks", fmt.Sprintf("fizzy webhook list --board %s", boardID), "List webhooks"),
 		}
 
-		printMutation(map[string]any{}, "", breadcrumbs)
+		printMutation(data, "", breadcrumbs)
 		return nil
 	},
 }

internal/commands/webhook_test.go

@@ -215,7 +215,10 @@ func TestWebhookShow(t *testing.T) {
 		if !result.Response.OK {
 			t.Error("expected success response")
 		}
-		if got := mock.GetWithPaginationCalls[0].Path; got != "/boards/board-1/webhooks/wh-1" {
+		if len(mock.GetCalls) != 1 {
+			t.Fatalf("expected 1 GET call, got %d", len(mock.GetCalls))
+		}
+		if got := mock.GetCalls[0].Path; got != "/boards/board-1/webhooks/wh-1" {
 			t.Errorf("expected path '/boards/board-1/webhooks/wh-1', got '%s'", got)
 		}
 	})
@@ -241,6 +244,7 @@ func TestWebhookCreate(t *testing.T) {
 		mock := NewMockClient()
 		mock.PostResponse = &client.APIResponse{
 			StatusCode: 201,
+			Location:   "/boards/board-1/webhooks/wh-new",
 			Data: map[string]any{
 				"id":          "wh-new",
 				"name":        "My Hook",
@@ -276,6 +280,9 @@ func TestWebhookCreate(t *testing.T) {
 		if body["url"] != "https://example.com/hook" {
 			t.Errorf("expected url 'https://example.com/hook', got '%v'", body["url"])
 		}
+		if got := result.Response.Context["location"]; got != "/boards/board-1/webhooks/wh-new" {
+			t.Errorf("expected location context, got %v", got)
+		}
 	})
 
 	t.Run("creates webhook with actions", func(t *testing.T) {
@@ -472,7 +479,7 @@ func TestWebhookReactivate(t *testing.T) {
 			},
 		}
 
-		SetTestModeWithSDK(mock)
+		result := SetTestModeWithSDK(mock)
 		SetTestConfig("token", "account", "https://api.example.com")
 		defer resetTest()
 
@@ -484,6 +491,13 @@ func TestWebhookReactivate(t *testing.T) {
 		if mock.PostCalls[0].Path != "/boards/board-1/webhooks/wh-1/activation.json" {
 			t.Errorf("expected path '/boards/board-1/webhooks/wh-1/activation.json', got '%s'", mock.PostCalls[0].Path)
 		}
+		data, ok := result.Response.Data.(map[string]any)
+		if !ok {
+			t.Fatalf("expected response data map, got %T", result.Response.Data)
+		}
+		if data["id"] != "wh-1" || data["active"] != true {
+			t.Fatalf("expected activated webhook data, got %#v", data)
+		}
 	})
 
 	t.Run("requires board", func(t *testing.T) {