Add ASCII banner and CEO welcome message for new signups (#80)

* Add braille art banner to fizzy, setup, and signup commands

Show the README's braille art banner in interactive terminal sessions:
- bare `fizzy` command (before help output)
- `fizzy setup` (before the setup wizard)
- `fizzy signup` (before the signup wizard)

The banner is printed to stderr and only displays when connected to a
TTY, so it never appears in piped, --json, --agent, or --quiet output.

* Add CEO welcome message for new user signups

Show a personal welcome message from Jason Fried after new users
complete signup. Includes braille signature art in interactive mode
and a welcome_message field in JSON output for programmatic/agent use.
Agent skill updated to require displaying the message.

* Fix gosec lint: use blank identifier for cmd.Help() error

* Print banner to stdout and include signature in machine welcome message

Address Copilot review: use stdout for banner to match other interactive
output, and include the signature in machine output welcome_message for
consistency with interactive output.

* Preserve existing profile fields in ensureProfile

Read the existing profile before creating/replacing so that Extra
entries (like board) and non-default BaseURL values survive calls
that pass empty values for those fields (auth login, migrateLegacyToken).

* Consolidate authLogoutAll into a single loop

Eliminate the second profiles.List() call by deleting credentials and
profiles in the same iteration over the collected names.

* Use t.TempDir() instead of os.MkdirTemp in signup tests

Removes manual cleanup and lets the test framework handle temp
directory lifecycle.

* Remove DNS resolution from validateSignupURL to fix TOCTOU

Only allow literal loopback addresses (localhost, 127.0.0.1, ::1)
for http:// URLs. DNS lookups at validation time can return different
results than at connection time, creating a TOCTOU race.

* Apply target profile's board when switching profiles

Read the board from the target profile's Extra instead of
unconditionally clearing it, so profile-specific boards survive
auth switch.

* Print banner to stderr to avoid mixing with command output

* Use actual CLI version in signup User-Agent header

* Warn when FIZZY_ACCOUNT env var is used instead of FIZZY_PROFILE

* Check stderr TTY status to match banner output destination

* Cache profileEnvVar() result to avoid duplicate deprecation warning

* Fix ensureProfile preserving stale BaseURL on hosted re-signup

Only preserve existing BaseURL when the caller passes empty string
(meaning "I don't care"). Passing config.DefaultAPIURL now correctly
overwrites a previously-saved self-hosted URL.

* Guard banner on machine flags and stderr TTY, not IsMachineOutput

IsMachineOutput checks stdout, but the banner writes to stderr.
Check machine format flags directly and gate on stderr TTY state
so the banner shows when stderr is a terminal regardless of stdout
piping, and is suppressed when stderr itself is redirected.

* Rewrite welcome message copy for CLI context

Replace GUI-specific language ("You'll see the Playground when you
close this message") with CLI-appropriate direction ("Try fizzy board
list to see it").

* Fix ensureProfile doc comment to match implementation

* Soften welcome message to not assert Playground board exists

Use "You should find a Playground board" instead of asserting it
was set up, since the CLI can't verify server-side board provisioning.

* Emit FIZZY_ACCOUNT deprecation warning on no-profiles path

The early return at resolveProfile:670-678 read FIZZY_ACCOUNT
directly, bypassing profileEnvVar() and its deprecation warning.
Route through profileEnvVar() so the warning fires consistently.

* Add tests for ensureProfile BaseURL overwrite and preservation

Cover the hosted re-signup case (default URL overwrites self-hosted)
and the empty-string case (existing BaseURL is preserved).

* Clear stale board from profile when setup user selects "None"

ensureProfile preserves existing Extra entries when board is empty
(to avoid clobbering boards during auth login/signup). Setup is the
only caller where empty board means "user explicitly chose no board,"
so handle the clearing there directly.

---------

Co-authored-by: Jeremy Daer <jeremy@37signals.com>

Author: robzolkos

internal/commands/auth.go

@@ -131,38 +131,35 @@ var authLogoutCmd = &cobra.Command{
 }
 
 func authLogoutAll() error {
-	if creds != nil {
-		// Collect all known profile/account names to clean up every key format
-		names := map[string]bool{}
+	// Collect all known profile/account names to clean up every key format
+	names := map[string]bool{}
 
-		if profiles != nil {
-			allProfiles, _, _ := profiles.List()
-			for name := range allProfiles {
-				names[name] = true
-			}
+	if profiles != nil {
+		allProfiles, _, _ := profiles.List()
+		for name := range allProfiles {
+			names[name] = true
 		}
+	}
 
-		// Also include the YAML config's Account in case it's not in the profile store
-		globalCfg := config.LoadGlobal()
-		if globalCfg.Account != "" {
-			names[globalCfg.Account] = true
-		}
+	// Also include the YAML config's Account in case it's not in the profile store
+	globalCfg := config.LoadGlobal()
+	if globalCfg.Account != "" {
+		names[globalCfg.Account] = true
+	}
 
-		for name := range names {
+	for name := range names {
+		if creds != nil {
 			_ = credsDeleteProfileToken(name) // "profile:<name>"
 			_ = creds.Delete("token:" + name) // legacy "token:<account>"
 		}
-		// Legacy bare key
-		_ = creds.Delete("token")
-	}
-
-	// Delete all profiles from the store
-	if profiles != nil {
-		allProfiles, _, _ := profiles.List()
-		for name := range allProfiles {
+		if profiles != nil {
 			_ = profiles.Delete(name)
 		}
 	}
+	if creds != nil {
+		// Legacy bare key
+		_ = creds.Delete("token")
+	}
 
 	// Clear config
 	if err := config.Delete(); err != nil {
@@ -326,17 +323,28 @@ var authSwitchCmd = &cobra.Command{
 			}
 		}
 
+		// Read the target profile's board from Extra
+		var profileBoard string
+		if profiles != nil {
+			if p, err := profiles.Get(profileName); err == nil {
+				if boardRaw, ok := p.Extra["board"]; ok {
+					_ = json.Unmarshal(boardRaw, &profileBoard)
+				}
+			}
+		}
+
 		// Update YAML config for backward compat
 		globalCfg := config.LoadGlobal()
 		globalCfg.Account = profileName
-		globalCfg.Board = "" // Clear board since it's profile-specific
+		globalCfg.Board = profileBoard
 		if err := globalCfg.Save(); err != nil {
 			return &output.Error{Code: output.CodeAPI, Message: err.Error()}
 		}
 
 		// Update in-memory config
 		if cfg != nil {
 			cfg.Account = profileName
+			cfg.Board = profileBoard
 			if creds != nil {
 				if t, err := credsLoadProfileToken(profileName); err == nil {
 					cfg.Token = t

internal/commands/auth_test.go

@@ -1136,6 +1136,67 @@ func TestEnsureProfileUpdatesExisting(t *testing.T) {
 			t.Errorf("expected board 'new-board', got '%s'", board)
 		}
 	})
+
+	t.Run("overwrites self-hosted BaseURL with default on hosted re-signup", func(t *testing.T) {
+		profileDir := t.TempDir()
+		profileStore := profile.NewStore(filepath.Join(profileDir, "config.json"))
+		profileStore.Create(&profile.Profile{
+			Name:    "acme",
+			BaseURL: "https://selfhosted.example.com",
+			Extra: map[string]json.RawMessage{
+				"board": json.RawMessage(`"old-board"`),
+			},
+		})
+
+		mock := NewMockClient()
+		SetTestMode(mock)
+		SetTestProfiles(profileStore)
+		defer ResetTestMode()
+
+		// Re-signup with default URL should overwrite the self-hosted URL
+		ensureProfile("acme", config.DefaultAPIURL, "")
+
+		p, err := profileStore.Get("acme")
+		if err != nil {
+			t.Fatalf("expected profile to exist: %v", err)
+		}
+		if p.BaseURL != config.DefaultAPIURL {
+			t.Errorf("expected BaseURL '%s', got '%s'", config.DefaultAPIURL, p.BaseURL)
+		}
+		// Board should be preserved since we passed empty
+		var board string
+		if boardRaw, ok := p.Extra["board"]; ok {
+			json.Unmarshal(boardRaw, &board)
+		}
+		if board != "old-board" {
+			t.Errorf("expected board 'old-board' to be preserved, got '%s'", board)
+		}
+	})
+
+	t.Run("preserves existing BaseURL when caller passes empty", func(t *testing.T) {
+		profileDir := t.TempDir()
+		profileStore := profile.NewStore(filepath.Join(profileDir, "config.json"))
+		profileStore.Create(&profile.Profile{
+			Name:    "acme",
+			BaseURL: "https://custom.example.com",
+		})
+
+		mock := NewMockClient()
+		SetTestMode(mock)
+		SetTestProfiles(profileStore)
+		defer ResetTestMode()
+
+		// Empty baseURL should preserve the existing one
+		ensureProfile("acme", "", "")
+
+		p, err := profileStore.Get("acme")
+		if err != nil {
+			t.Fatalf("expected profile to exist: %v", err)
+		}
+		if p.BaseURL != "https://custom.example.com" {
+			t.Errorf("expected BaseURL 'https://custom.example.com', got '%s'", p.BaseURL)
+		}
+	})
 }
 
 func TestAuthLogoutAllCleansLegacyKeys(t *testing.T) {

internal/commands/banner.go

@@ -0,0 +1,35 @@
+package commands
+
+import (
+	"fmt"
+	"os"
+
+	"github.com/mattn/go-isatty"
+)
+
+const banner = `
+⠀⡀⠄⠀⣤⣤⡄⠠⢠⣤⣤⠀⠄⣠⣤⣤⠀⠠⣠⣤⣄⠠⠀⣤⣤⡄⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀⠠⠀
+⠀⠀⠄⢸⣿⣿⡇⠠⢸⣿⣿⡇⠀⣿⣿⡿⡇⢈⣿⣿⣿⠀⢸⣿⣿⡇⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⢀⠈⠠⠈⢀⠈⡀⢈⠀⡈⢀⠈⡀⢈⠀⡈⠠⠀
+⠀⢁⠠⢸⣿⡿⡇⠀⢸⣿⡿⡇⠀⣿⣿⢿⡃⠠⣿⣿⣾⠀⢸⣿⣽⡇⠀⠠⠀⠄⠠⠀⣦⣦⣦⣦⣦⣦⣦⣦⣦⠀⢰⣾⣷⡦⠀⠄⠠⠀⠄⠠⠀⠄⠠⠀⠄⠠⠀⠄⠠⠀⠄⠐⢀⠈⡀⠠⠀⠄⠠⠀⠄⠠⠀⠄⠠⠀⠐⠀
+⠀⠠⠀⢸⣿⣿⡇⠈⢸⣿⣿⡇⠀⣿⣿⣿⠇⢈⣿⣷⣿⠀⢸⣿⣽⡇⠀⠂⠐⠀⠂⡀⣿⣿⡟⠛⠛⠛⠛⠛⠛⠀⠄⠉⠉⢁⠀⠂⠐⠀⠂⠐⠀⠂⠐⠀⠂⠐⠀⠂⠐⠀⠂⠁⠠⠀⠄⠐⠀⠂⠐⠀⠂⠐⠀⠂⠐⠈⡀⠁
+⠀⠂⠈⢸⣿⣯⡇⠠⢸⣿⣯⡇⠀⣿⣿⣾⡇⠐⣿⣯⣿⠀⢸⣿⣽⡇⠀⡁⢈⠀⡁⠀⣿⣿⡇⠀⠄⠂⠀⠂⠐⢀⢸⣿⣿⡇⠀⡁⣿⣿⣿⣿⣿⣿⣿⣿⡃⢈⠀⣿⣿⣿⣿⣿⣿⣿⣿⠅⠈⢿⣿⣿⡀⢁⠈⡀⣽⣿⣿⠃
+⠀⡈⠠⢸⣿⡿⡇⠀⢸⣿⡿⡇⠀⣿⣿⣽⡆⠨⣿⣟⣿⠀⢸⣯⣿⡇⠀⠄⠠⠀⠄⠂⣿⣿⢷⣶⣶⣶⣷⣾⡆⢀⢸⣿⣻⡇⠀⡀⠉⡈⠁⣁⣵⣿⣿⠋⠀⠠⠀⢉⠈⢁⢁⣵⣿⡿⠋⠀⠐⠘⣿⣿⣧⠀⠄⢠⣿⣿⠎⠀
+⠀⠠⠀⢸⣿⣿⡇⠈⢸⣿⣿⡇⠀⣿⣿⣻⡅⠐⠿⣿⠟⠀⢸⣿⣽⡇⠀⠂⠐⠀⠂⡀⣿⣿⡟⠛⠛⠋⠛⠛⠃⠀⢸⣟⣿⡇⠀⠄⠂⠠⣰⣾⣿⠟⠁⢀⠈⠠⠈⢀⢠⣰⣿⡿⠟⠀⡀⢁⠈⡀⠸⣿⣾⡇⢀⣿⣿⡟⠀⠄
+⠀⠂⠈⠸⣿⣯⡇⠠⢸⣿⣯⡇⠀⣿⣿⢿⡃⠠⠀⡢⠀⡁⠘⣿⣽⡇⠀⡁⢈⠀⢁⠀⣿⣿⡇⠀⠐⠀⠂⠐⠀⡁⢸⣿⣟⡇⢀⠐⣠⣶⣿⡟⠃⢀⠐⠀⡐⢀⠈⣠⣾⣿⡗⠋⠀⠄⠠⠀⠄⠀⠂⢹⣿⣷⣼⣿⡿⠀⠐⠀
+⠀⡈⢀⠁⠉⡏⠀⠠⢸⣿⡿⡇⠀⣿⣿⣿⠇⠀⠂⢜⠀⡀⠂⠉⡏⠀⠄⠠⠀⠐⢀⠀⣿⣿⡇⠀⡁⢈⠀⡁⠄⠠⢸⣿⣽⡇⠀⡀⣿⣿⣻⣿⣿⣿⣿⣿⡇⠀⢐⣿⣿⣷⣿⣿⣿⣿⣿⡇⢀⠁⡈⠀⢹⣿⣻⣽⠁⢀⠁⠄
+⠀⠠⠀⠐⠀⡇⠈⡀⢸⣿⣿⡇⠀⠙⢻⠊⠠⠈⡀⢕⠀⠠⠐⠀⡇⠐⠀⠂⢈⠠⠀⠄⢀⠀⡀⠄⠠⠀⠄⠠⠀⠂⢀⠀⡀⠠⠀⠄⢀⠀⡀⠀⡀⠀⡀⠀⡀⠐⢀⠀⡀⠀⡀⠀⡀⠀⡀⠀⠄⠠⣀⣈⣸⣿⣿⠃⠀⠄⠐⠀
+⠀⠐⠈⢀⠁⡇⠠⠀⠸⢿⡯⠃⢀⠁⢸⠀⠂⠠⠀⠪⠀⠐⠀⠁⡇⢀⠁⡈⢀⠠⠐⠀⠄⠠⠀⠄⠂⠐⠀⠂⡀⢁⠠⠀⠄⠐⠀⠂⠠⠀⠄⠂⠀⠂⠀⠂⡀⢈⠀⠠⠀⠂⠀⠂⠀⠂⠀⠂⠐⠰⣿⣿⠿⠟⠁⡀⠂⡀⠁⠄
+⠀⢁⠈⢀⠠⠐⠀⡈⠠⠀⡀⠄⠠⠐⠀⠂⠁⠐⠀⠂⡈⢀⠁⠐⡀⠄⠠⠀⠄⢀⠐⠀⠂⠐⠀⠂⡀⢁⠈⡀⠄⠠⠀⠐⢀⠈⡀⢁⠐⢀⠐⠀⡁⢈⠀⡁⠀⠄⠐⠀⠂⠁⡈⢀⠁⡈⢀⠁⡈⢀⠀⡀⠄⠂⠁⠀⠄⠠⠈⠀
+`
+
+// printBanner prints the Fizzy braille art banner to stderr.
+// Suppressed when machine format flags are set or stderr is not a TTY.
+func printBanner() {
+	if cfgAgent || cfgJSON || cfgQuiet || cfgIDsOnly || cfgCount {
+		return
+	}
+	if !isatty.IsTerminal(os.Stderr.Fd()) && !isatty.IsCygwinTerminal(os.Stderr.Fd()) {
+		return
+	}
+	fmt.Fprint(os.Stderr, banner)
+}

internal/commands/root.go

@@ -65,6 +65,10 @@ var rootCmd = &cobra.Command{
 
 Use fizzy to manage boards, cards, comments, and more from your terminal.`,
 	Version: "dev",
+	Run: func(cmd *cobra.Command, args []string) {
+		printBanner()
+		_ = cmd.Help()
+	},
 	PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
 		// Resolve output format from parsed flags (must happen post-parse).
 		format, err := resolveFormat()
@@ -666,24 +670,23 @@ func resolveProfile() error {
 	allProfiles, defaultName, err := profiles.List()
 	if err != nil || len(allProfiles) == 0 {
 		// No profiles configured — fall back to env var for account
-		if p := os.Getenv("FIZZY_PROFILE"); p != "" {
-			cfg.Account = p
-		} else if a := os.Getenv("FIZZY_ACCOUNT"); a != "" {
-			cfg.Account = a
+		if v := profileEnvVar(); v != "" {
+			cfg.Account = v
 		}
 		return nil
 	}
 
+	envProfile := profileEnvVar()
 	resolved, err := profile.Resolve(profile.ResolveOptions{
 		FlagValue:      cfgProfile,
-		EnvVar:         profileEnvVar(),
+		EnvVar:         envProfile,
 		DefaultProfile: defaultName,
 		Profiles:       allProfiles,
 	})
 	if err != nil {
 		// If the user explicitly specified a profile (flag or env), that's a
 		// hard error — don't silently fall back to a different account.
-		if cfgProfile != "" || profileEnvVar() != "" {
+		if cfgProfile != "" || envProfile != "" {
 			return err
 		}
 		// Otherwise (ambiguous default, etc.) — not fatal, just skip profile
@@ -719,7 +722,11 @@ func profileEnvVar() string {
 	if v := os.Getenv("FIZZY_PROFILE"); v != "" {
 		return v
 	}
-	return os.Getenv("FIZZY_ACCOUNT")
+	if v := os.Getenv("FIZZY_ACCOUNT"); v != "" {
+		fmt.Fprintln(os.Stderr, "Warning: FIZZY_ACCOUNT is deprecated, use FIZZY_PROFILE instead")
+		return v
+	}
+	return ""
 }
 
 // resolveToken applies token precedence: YAML → credstore (with migration) → env → flag.
@@ -783,29 +790,45 @@ func migrateLegacyToken(profileName string) {
 }
 
 // ensureProfile creates or updates a profile in the store.
-// If the profile already exists, it is replaced with the new settings.
+// If the profile already exists, fields are merged: BaseURL is
+// preserved only when the caller passes an empty string (meaning
+// "keep whatever is there"), and Extra entries are preserved unless
+// explicitly replaced.
 func ensureProfile(name, baseURL, board string) {
 	if profiles == nil {
 		return
 	}
-	if baseURL == "" {
-		baseURL = config.DefaultAPIURL
+
+	existing, _ := profiles.Get(name)
+
+	newBaseURL := baseURL
+	if newBaseURL == "" {
+		if existing != nil && existing.BaseURL != "" {
+			newBaseURL = existing.BaseURL
+		} else {
+			newBaseURL = config.DefaultAPIURL
+		}
+	}
+
+	extra := map[string]json.RawMessage{}
+	if existing != nil {
+		for k, v := range existing.Extra {
+			extra[k] = v
+		}
+	}
+	if board != "" {
+		extra["board"] = func() json.RawMessage { b, _ := json.Marshal(board); return b }()
 	}
 
 	p := &profile.Profile{
 		Name:    name,
-		BaseURL: baseURL,
+		BaseURL: newBaseURL,
 	}
-	if board != "" {
-		p.Extra = map[string]json.RawMessage{
-			"board": func() json.RawMessage { b, _ := json.Marshal(board); return b }(),
-		}
+	if len(extra) > 0 {
+		p.Extra = extra
 	}
 
 	if err := profiles.Create(p); err != nil {
-		// Profile already exists — delete and recreate to update it.
-		// Preserve default status: if this profile was the default, SetDefault
-		// is called by the caller (login/setup/signup/switch) anyway.
 		_ = profiles.Delete(name)
 		_ = profiles.Create(p)
 	}

internal/commands/setup.go

@@ -41,6 +41,7 @@ func runSetup(cmd *cobra.Command, args []string) error {
 		return output.ErrUsageHint("setup requires an interactive terminal", "Run without --agent/--json/--quiet or in a TTY")
 	}
 
+	printBanner()
 	fmt.Println()
 	fmt.Println("Welcome to Fizzy CLI setup!")
 	fmt.Println()
@@ -255,6 +256,14 @@ func runSetup(cmd *cobra.Command, args []string) error {
 
 		// Create/update profile
 		ensureProfile(selectedAccountSlug, apiURL, selectedBoardID)
+		// If user chose "None (skip)", clear any previously saved board
+		if selectedBoardID == "" && profiles != nil {
+			if p, err := profiles.Get(selectedAccountSlug); err == nil {
+				delete(p.Extra, "board")
+				_ = profiles.Delete(selectedAccountSlug)
+				_ = profiles.Create(p)
+			}
+		}
 		if profiles != nil {
 			_ = profiles.SetDefault(selectedAccountSlug)
 		}