Skip to content

Commit b6714d9

Browse files
committed
Print banner to stdout and include signature in machine welcome message
Address Copilot review: use stdout for banner to match other interactive output, and include the signature in machine output welcome_message for consistency with interactive output.
1 parent 78df6ba commit b6714d9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

internal/commands/banner.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ const banner = `
2222
⠀⢁⠈⢀⠠⠐⠀⡈⠠⠀⡀⠄⠠⠐⠀⠂⠁⠐⠀⠂⡈⢀⠁⠐⡀⠄⠠⠀⠄⢀⠐⠀⠂⠐⠀⠂⡀⢁⠈⡀⠄⠠⠀⠐⢀⠈⡀⢁⠐⢀⠐⠀⡁⢈⠀⡁⠀⠄⠐⠀⠂⠁⡈⢀⠁⡈⢀⠁⡈⢀⠀⡀⠄⠂⠁⠀⠄⠠⠈⠀
2323
`
2424

25-
// printBanner prints the Fizzy braille art banner to stderr.
25+
// printBanner prints the Fizzy braille art banner to stdout.
2626
// Only prints in interactive TTY mode, never in machine/piped output.
2727
func printBanner() {
2828
if IsMachineOutput() {
2929
return
3030
}
31-
if !isatty.IsTerminal(os.Stderr.Fd()) && !isatty.IsCygwinTerminal(os.Stderr.Fd()) {
31+
if !isatty.IsTerminal(os.Stdout.Fd()) && !isatty.IsCygwinTerminal(os.Stdout.Fd()) {
3232
return
3333
}
34-
fmt.Fprint(os.Stderr, banner)
34+
fmt.Print(banner)
3535
}

internal/commands/signup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ func runSignupComplete(cmd *cobra.Command, args []string) error {
527527
summary := "Configuration saved."
528528

529529
if name != "" {
530-
result["welcome_message"] = welcomeMessage + "\n" + welcomeSignoff
530+
result["welcome_message"] = welcomeMessage + welcomeSignature + welcomeSignoff
531531
result["is_new_user"] = true
532532
}
533533

0 commit comments

Comments
 (0)