Skip to content

Commit a5a23e6

Browse files
committed
Add Go service generator and address all PR review findings
- Build Go service generator (go/cmd/generate-services/) that reads openapi.json and generates all 15 service files + operations registry, making Go the 5th SDK with spec-driven service generation - Fix Go services: response discarding bugs, wrong reaction request types, now all generated from spec - Split CreateReactionRequest into CreateCardReactionRequest and CreateCommentReactionRequest aliases - Fix TS generator: only import ListResult/PaginationOptions when service has paginated or array-returning operations - Fix Swift toCamelCase: always lowercase first character, fixing DirectUploadHeaders PascalCase properties - Fix Kotlin MetadataEmitter: default baseDelayMs to 1000L not 0L - Fix all drift check scripts: inline jq, use HTTP method allowlist instead of fragile blocklist filter - Restore conformance target to check dependencies - Remove unused responseStatus assertion type from conformance schema - Add go-generate-services Makefile target
1 parent 6af657b commit a5a23e6

33 files changed

Lines changed: 1054 additions & 487 deletions

Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
.PHONY: behavior-model behavior-model-check
44
.PHONY: url-routes url-routes-check
55
.PHONY: sync-api-version sync-api-version-check
6-
.PHONY: go-test go-lint go-check go-clean go-check-drift
6+
.PHONY: go-generate-services go-test go-lint go-check go-clean go-check-drift
77
.PHONY: ts-install ts-generate ts-generate-services ts-build ts-test ts-typecheck ts-check ts-check-drift ts-clean
88
.PHONY: rb-generate rb-generate-services rb-build rb-test rb-check rb-check-drift rb-clean
99
.PHONY: swift-build swift-test swift-check swift-check-drift swift-generate swift-clean
@@ -133,6 +133,10 @@ sync-status: ## Show upstream changes since last sync
133133
# Go SDK
134134
# ──────────────────────────────────────────────
135135

136+
go-generate-services: ## Generate Go service files from openapi.json
137+
@echo "==> Generating Go services..."
138+
cd go && go run ./cmd/generate-services/
139+
136140
go-test: ## Run Go tests
137141
@echo "==> Running Go tests..."
138142
cd go && go test ./pkg/fizzy/... -count=1 -race
@@ -363,7 +367,7 @@ audit-check: ## Check rubric audit freshness and must-pass criteria
363367
# Combined
364368
# ──────────────────────────────────────────────
365369

366-
check: smithy-check behavior-model-check url-routes-check sync-api-version-check provenance-check audit-check go-check ts-check rb-check swift-check kt-check ## Run all checks
370+
check: smithy-check behavior-model-check url-routes-check sync-api-version-check provenance-check audit-check go-check ts-check rb-check swift-check kt-check conformance ## Run all checks
367371
@echo "==> All checks passed"
368372

369373
clean: smithy-clean go-clean ts-clean rb-clean swift-clean kt-clean ## Clean all build artifacts

conformance/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"requestPath", "urlOrigin",
5151
"responseMeta",
5252
"responseBody", "errorMessage", "headerInjected",
53-
"requestScheme", "responseStatus", "requestBodyField"
53+
"requestScheme", "requestBodyField"
5454
]
5555
},
5656
"expected": {},

0 commit comments

Comments
 (0)