Fix Column.color schema drift: structured object, not string (#71)

* Fix Column.color schema drift: now a structured Color object

The live API returns column color as a {name, value} object, but the
Smithy spec typed Column.color as a plain String. Typed-SDK consumers
crashed with "json: cannot unmarshal object into Go struct field" when
calling Columns().Get/List.

Fixed by changing Column.color in spec/fizzy.smithy from String to the
existing Color struct, then regenerating openapi.json and all five SDK
surfaces (Go, TypeScript, Ruby, Kotlin, Swift). Added tests in each
language that decode a column response with an object-shaped color, so
this drift cannot regress silently.

Create/Update column inputs remain a string (the color value, e.g.
"var(--color-card-1)"), matching the upstream API docs.

* Address Column.color review feedback

Author: robzolkos

go/oapi-codegen.yaml

@@ -13,3 +13,5 @@ output-options:
   skip-fmt: false
   skip-prune: false
   prefer-skip-optional-pointer: true
+  overlay:
+    path: oapi-overlay.yaml

go/oapi-overlay.yaml

@@ -0,0 +1,14 @@
+overlay: 1.0.0
+info:
+  title: Fizzy Go codegen overrides
+  version: 0.0.0
+actions:
+  - target: $.components.schemas.Column.properties.color['$ref']
+    description: Replace Column.color ref with allOf so oapi-codegen honors field extensions.
+    remove: true
+  - target: $.components.schemas.Column.properties.color
+    description: Preserve optional pointer semantics for Column.color.
+    update:
+      allOf:
+        - $ref: '#/components/schemas/Color'
+      x-go-type-skip-optional-pointer: false

go/pkg/fizzy/columns_service_test.go

@@ -0,0 +1,95 @@
+package fizzy
+
+import (
+	"context"
+	"encoding/json"
+	"net/http"
+	"net/http/httptest"
+	"strings"
+	"testing"
+
+	"github.com/basecamp/fizzy-sdk/go/pkg/generated"
+)
+
+// TestGetColumnDecodesColorObject pins the Column.color schema as a structured
+// object (Color{name, value}) rather than a string. The live API returns
+// "color": {"name": "Blue", "value": "var(--color-card-1)"}, which previously
+// failed to unmarshal because the SDK typed it as a string.
+func TestGetColumnDecodesColorObject(t *testing.T) {
+	body := `{
+		"id": "abc123",
+		"name": "In Progress",
+		"color": {"name": "Blue", "value": "var(--color-card-1)"},
+		"created_at": "2026-04-30T00:00:00Z",
+		"cards_url": "https://example.com/cards"
+	}`
+
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "application/json")
+		w.WriteHeader(http.StatusOK)
+		_, _ = w.Write([]byte(body))
+	}))
+	defer server.Close()
+
+	client := NewClient(&Config{BaseURL: server.URL}, &StaticTokenProvider{Token: "test"})
+	col, _, err := client.ForAccount("999").Columns().Get(context.Background(), "board1", "abc123")
+	if err != nil {
+		t.Fatalf("Get: %v", err)
+	}
+	if col.Color == nil {
+		t.Fatal("Color is nil, want decoded Color object")
+	}
+	if col.Color.Name != "Blue" {
+		t.Errorf("Color.Name = %q, want Blue", col.Color.Name)
+	}
+	if col.Color.Value != "var(--color-card-1)" {
+		t.Errorf("Color.Value = %q, want var(--color-card-1)", col.Color.Value)
+	}
+}
+
+func TestColumnColorOptionalPointerOmitsAbsentColor(t *testing.T) {
+	var col generated.Column
+	if err := json.Unmarshal([]byte(`{"id":"abc123","name":"No Color","created_at":"2026-04-30T00:00:00Z"}`), &col); err != nil {
+		t.Fatalf("Unmarshal: %v", err)
+	}
+	if col.Color != nil {
+		t.Fatalf("Color = %+v, want nil for absent optional field", col.Color)
+	}
+	encoded, err := json.Marshal(col)
+	if err != nil {
+		t.Fatalf("Marshal: %v", err)
+	}
+	if strings.Contains(string(encoded), `"color"`) {
+		t.Fatalf("encoded Column contains absent color: %s", encoded)
+	}
+}
+
+// TestListColumnsDecodesColorObject mirrors the Get test for the list endpoint.
+func TestListColumnsDecodesColorObject(t *testing.T) {
+	body := `[
+		{"id": "c1", "name": "Triage", "color": {"name": "Gray", "value": "var(--color-card-1)"}, "created_at": "2026-04-30T00:00:00Z"},
+		{"id": "c2", "name": "Done",   "color": {"name": "Lime", "value": "var(--color-card-4)"}, "created_at": "2026-04-30T00:00:00Z"}
+	]`
+
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "application/json")
+		w.WriteHeader(http.StatusOK)
+		_, _ = w.Write([]byte(body))
+	}))
+	defer server.Close()
+
+	client := NewClient(&Config{BaseURL: server.URL}, &StaticTokenProvider{Token: "test"})
+	cols, _, err := client.ForAccount("999").Columns().List(context.Background(), "board1")
+	if err != nil {
+		t.Fatalf("List: %v", err)
+	}
+	if len(cols) != 2 {
+		t.Fatalf("len(cols) = %d, want 2", len(cols))
+	}
+	if cols[0].Color == nil || cols[1].Color == nil {
+		t.Fatalf("colors = %+v / %+v, want decoded Color objects", cols[0].Color, cols[1].Color)
+	}
+	if cols[0].Color.Name != "Gray" || cols[1].Color.Value != "var(--color-card-4)" {
+		t.Errorf("unexpected colors: %+v / %+v", cols[0].Color, cols[1].Color)
+	}
+}

go/pkg/generated/types.gen.go

@@ -26,22 +26,6 @@ class ModelEmitter(private val api: OpenApiParser) {
             ?.toSet()
             ?: emptySet()
 
-        val lines = mutableListOf<String>()
-        lines += "package com.basecamp.fizzy.generated.models"
-        lines += ""
-        lines += "import kotlinx.serialization.SerialName"
-        lines += "import kotlinx.serialization.Serializable"
-        lines += "import kotlinx.serialization.json.JsonElement"
-        lines += "import kotlinx.serialization.json.JsonObject"
-        lines += ""
-        lines += "/**"
-        lines += " * $typeName entity from the Fizzy API."
-        lines += " *"
-        lines += " * @generated from OpenAPI spec -- do not edit directly"
-        lines += " */"
-        lines += "@Serializable"
-        lines += "data class $typeName("
-
         // Required fields first (no defaults), then optional fields (with defaults)
         val requiredProps = mutableListOf<Pair<String, JsonObject>>()
         val optionalProps = mutableListOf<Pair<String, JsonObject>>()
@@ -54,11 +38,17 @@ class ModelEmitter(private val api: OpenApiParser) {
         }
 
         val propLines = mutableListOf<String>()
+        var usesSerialName = false
+        var usesJsonElement = false
+        var usesJsonObject = false
         for ((propName, propObj) in requiredProps + optionalProps) {
             val isRequired = propName in requiredFields
             val kotlinType = resolvePropertyType(propObj, isRequired)
             val camelName = propName.snakeToCamelCase()
             val needsSerialName = camelName != propName
+            usesSerialName = usesSerialName || needsSerialName
+            usesJsonElement = usesJsonElement || kotlinType.contains("JsonElement")
+            usesJsonObject = usesJsonObject || kotlinType.contains("JsonObject")
 
             val propLine = buildString {
                 if (needsSerialName) {
@@ -74,6 +64,21 @@ class ModelEmitter(private val api: OpenApiParser) {
             propLines += propLine
         }
 
+        val lines = mutableListOf<String>()
+        lines += "package com.basecamp.fizzy.generated.models"
+        lines += ""
+        if (usesSerialName) lines += "import kotlinx.serialization.SerialName"
+        lines += "import kotlinx.serialization.Serializable"
+        if (usesJsonElement) lines += "import kotlinx.serialization.json.JsonElement"
+        if (usesJsonObject) lines += "import kotlinx.serialization.json.JsonObject"
+        lines += ""
+        lines += "/**"
+        lines += " * $typeName entity from the Fizzy API."
+        lines += " *"
+        lines += " * @generated from OpenAPI spec -- do not edit directly"
+        lines += " */"
+        lines += "@Serializable"
+        lines += "data class $typeName("
         lines += propLines.joinToString(",\n")
         lines += ")"
 

kotlin/generator/src/main/kotlin/com/basecamp/fizzy/generator/ModelEmitter.kt

@@ -2,8 +2,6 @@ package com.basecamp.fizzy.generated.models
 
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
 
 /**
  * Account entity from the Fizzy API.

kotlin/sdk/src/commonMain/kotlin/com/basecamp/fizzy/generated/models/Account.kt

@@ -2,8 +2,6 @@ package com.basecamp.fizzy.generated.models
 
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
 
 /**
  * Activity entity from the Fizzy API.

kotlin/sdk/src/commonMain/kotlin/com/basecamp/fizzy/generated/models/Activity.kt

@@ -2,8 +2,6 @@ package com.basecamp.fizzy.generated.models
 
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
 
 /**
  * ActivityEventable entity from the Fizzy API.

kotlin/sdk/src/commonMain/kotlin/com/basecamp/fizzy/generated/models/ActivityEventable.kt

@@ -2,8 +2,6 @@ package com.basecamp.fizzy.generated.models
 
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
 
 /**
  * ActivityParticulars entity from the Fizzy API.

kotlin/sdk/src/commonMain/kotlin/com/basecamp/fizzy/generated/models/ActivityParticulars.kt

@@ -2,8 +2,6 @@ package com.basecamp.fizzy.generated.models
 
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.json.JsonElement
-import kotlinx.serialization.json.JsonObject
 
 /**
  * Board entity from the Fizzy API.