Resolve through EasyEffects to its configured output device - #8713
Open
tzssangglass wants to merge 1 commit into
Open
Resolve through EasyEffects to its configured output device#8713tzssangglass wants to merge 1 commit into
tzssangglass wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tzssangglass
marked this pull request as draft
August 28, 2026 03:19
The sink-input scan misses EasyEffects because it forwards through direct PipeWire node links that never appear as PulseAudio streams. Volume keys and the audio panel then end up adjusting the virtual easyeffects_sink: the OSD moves while loudness stays put -- an autogain or limiter in the chain normalizes the change away. EasyEffects persists its configured output device in easyeffectsrc, so read the physical sink from there when the stream scan finds nothing. The device is validated against the live sink list, and anything unexpected falls through to the existing behavior.
tzssangglass
force-pushed
the
fix/easyeffects-output-sink-resolution
branch
from
August 28, 2026 07:38
6ad5908 to
f6eb5ae
Compare
tzssangglass
marked this pull request as ready for review
August 28, 2026 07:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With Easy Effects as the default output ("Process all outputs"), the volume keys, the OSD, and the audio panel slider adjust the virtual
easyeffects_sinkinstead of the physical sink:autogain), the input-level change is normalized away -- the OSD moves while the speakers stay exactly as loud.Root cause
omarchy-audio-output-sinkresolves a DSP sink's physical output by scanningpactl list sink-inputsfor the forwarding stream (matching the sink name, orapplication.name = "EasyEffects"). Current EasyEffects forwards through direct PipeWire node links (ee_soe_output_level:output_* -> alsa_output...:playback_*), which never appear as PulseAudio sink-inputs at all. The scan finds nothing, so the script falls back to returningeasyeffects_sinkitself -- exactly the case the header comment warns about: "the display moves while the speakers do not".Verified live: during active playback through Easy Effects,
pactl list sink-inputsshows only the apps playing intoeasyeffects_sink; no EasyEffects stream toward the physical sink exists.Fix
EasyEffects persists its configured output device in
~/.config/easyeffects/db/easyeffectsrc([StreamOutputs] outputDevice=). When the stream scan finds nothing and the selected sink iseasyeffects_sink, read the physical sink from there:pactl list sinks short), so a stale/unplugged device falls through to the existing fallback unchangedReproduction
Verification
Tested on Omarchy 4.0.1 with Easy Effects 7.x, PipeWire/WirePlumber.