Ability to disable or limit attachments

[orhanekici]

I would like to disable attachments for one instance and limit in another. I believe this would be a great option. We are using Campfire as a community chat hub but large attachments will eat up space very fast.

[monorkin]

Agreed, can you contribute a PR for this kind of feature or are you just sharing the idea?
I think it would be worth exploring global limits for attachments.

[orhanekici]

I would love to contribute a PR but sadly I have no experience with Rails. So it's just an idea.

[milos-dukic]

hey @monorkin I can take a look at it :). Although I have couple of questions if you don't mind:

1. This should be feature controlled by env variable e.g. MAX_ATTACHMENT_SIZE_IN_BYTES?
2. The check should be done on UI/FE via JS, but do we need to double check it on the BE before creating the attachment in the DB like e.g. in create_with_attachment! in app/models/message/attachment.rb?
3. Since we need the ENV variable in the JS part, we would need to pass it somehow, is it OK to do via tags, or we can pass it somehow to the Stimulus controller via data- in html.erb file?
4. If this feature is set, should there be any info about it, like at the top/bottom of the input line like:

5. If someone attaches file over MAX size, should we then display the text from the item 4?

Thx :)

[milos-dukic]

@monorkin I created a PR for this feature: #115