Drop unnecessary type casts; add tests for persisted defaults

Author: jeremy

src/adapters/onboarding.ts

@@ -379,8 +379,8 @@ export const basecampOnboardingAdapter: ChannelOnboardingAdapter = {
         basecamp: {
           ...section,
           enabled: true,
-          dmPolicy: (section as any)?.dmPolicy ?? "pairing",
-          engage: (section as any)?.engage ?? DEFAULT_ENGAGE,
+          dmPolicy: section.dmPolicy ?? "pairing",
+          engage: section.engage ?? DEFAULT_ENGAGE,
           ...(channelOauth ? { oauth: channelOauth } : {}),
           accounts: {
             ...accounts,

tests/onboarding.test.ts

@@ -306,6 +306,47 @@ describe("basecampOnboardingAdapter", () => {
       expect(account.oauthClientSecret).toBeUndefined();
       // Channel-level oauth should be set from prompted creds
       expect(result.cfg.channels.basecamp.oauth?.clientId).toBe("test-client-id");
+      // Defaults persisted for fresh onboarding
+      expect(result.cfg.channels.basecamp.dmPolicy).toBe("pairing");
+      expect(result.cfg.channels.basecamp.engage).toEqual(["dm", "mention", "assignment", "checkin"]);
+    });
+
+    it("re-running configure preserves existing dmPolicy and engage values", async () => {
+      mockCliProfileListFull.mockRejectedValue(new Error("not installed"));
+      mockResolveTokenFilePath.mockReturnValue("/tmp/tokens/default.json");
+      mockInteractiveLogin.mockResolvedValue({
+        accessToken: "tok",
+        refreshToken: "ref",
+        tokenType: "Bearer",
+      });
+      mockDiscoverIdentity.mockResolvedValue({
+        identity: { id: 42, firstName: "Bot", lastName: "", emailAddress: "b@t.com" },
+        accounts: [{ id: 100, name: "Co", product: "bc3" }],
+      });
+
+      const prompter = createPrompter({
+        selectAnswers: ["done"],
+      });
+
+      const existingCfg = cfg({
+        dmPolicy: "disabled",
+        engage: ["dm"],
+        oauth: { clientId: "aabbccdd00112233445566778899aabbccddeeff" },
+        accounts: { default: { personId: "42", oauthTokenFile: "/tmp/tokens/default.json" } },
+      });
+
+      const result = await basecampOnboardingAdapter.configure({
+        cfg: existingCfg,
+        runtime: {} as any,
+        prompter,
+        accountOverrides: {},
+        shouldPromptAccountIds: false,
+        forceAllowFrom: false,
+      });
+
+      // Existing values must survive — not overwritten with defaults
+      expect(result.cfg.channels.basecamp.dmPolicy).toBe("disabled");
+      expect(result.cfg.channels.basecamp.engage).toEqual(["dm"]);
     });
 
     it("uses existing channel-level OAuth clientId without prompting", async () => {