Incompatible: Remove legacy allowlist names

[comius]

The change removes legacy _whitelist_function_transition.

First merged and rolled back:
10a46b1

The naming is in use in old rules_go, which several projects haven't upgraded.

[comius]

Help needed:

• rules_jsonnet breakage : rules_jsonnet is failing at Bazel@HEAD bazel-contrib/rules_jsonnet#173
  • Update go-jsonnet bazel-contrib/rules_jsonnet#174
  • PR is failing on go_dependency, help needed

Pending fixes:

• Bazelisk: breakage: Bazelisk is failing at Bazel@HEAD bazelisk#497
  • fix pending: Update rules_go bazelisk#498
• Bazel skylib: breakage bazel-skylib is failing at BAZEL@HEAD bazel-skylib#459
  • preexisting failure, build failing at head: analysis_test_e2e_test is failing with Bazel@HEAD bazel-skylib#458
  • fix pending: Upgrade rules_go bazel-skylib#460

Fixed (not verified):

• rules_sass breakage: rules_sass is failing at Bazel@HEAD rules_sass#151
  • Update rules_go rules_sass#152
• FlatBuffers: breakage: flatbuffers is failing at BAZEL@HEAD google/flatbuffers#8091
  • Upgrade rules_go google/flatbuffers#8092
• rules_python: breakage: rules_python is failing at BAZEL@HEAD bazel-contrib/rules_python#1409
  • fix pending: fix(gazelle): upgrade rules_go: 0.39.1 -> 0.41.0 to work with upcoming Bazel versions bazel-contrib/rules_python#1410
• rules_dotnet breakage: rules_dotnet is failing at Bazel@HEAD bazel-contrib/rules_dotnet#375
  • Upgrade rules_go bazel-contrib/rules_dotnet#376
  • • rules_android: breakage: rules_android is at failing at head (using last released Bazel) rules_android#134
  • will resolve when build is fixed at head:
• rules_cc: breakage: Update dependency io_bazel_rules_go to v0.18.6 rules_cc#19
• fix pending internally
• rules_closure: breakage: rules_closure is failing at Bazel@HEAD rules_closure#586
  • Upgrade rules_go rules_closure#587

rules_docker was archived:

• rules_docker has preexisting problem: Bazel CI: rules_docker still failing with Bazel@HEAD rules_docker#1988
  • Help/investigation needed with rules_docker/gazelle: Error: file '@bazel_tools//tools/build_defs/repo:utils.bzl' does not contain symbol 'read_user_netrc', happening in gazelle repo (see https://buildkite.com/bazel/rules-docker-docker/builds/6976#018a887a-ad48-4d05-b73a-31a4b12a515a)

Buildfarm depends on rules_docker:

• Buildfarm: breakage: Buildfarm is failing at Bazel@HEAD buildfarm/buildfarm#1440
  • rules_go coming from rules_docker: Update rules_go version rules_docker#2273

[comius]

cc @fmeum

[comius]

One month has passed, without maintainers upgrading rules_go. So I believe we can roll forward the change again.

[fmeum]

@comius Would you be supportive of a change to remove the allowlist attribute requirement for Bazel, for example via a flag that is unflipped within Google via a .blazerc line? I have never seen anyone specify a non-trivial package_group outside Google, especially not in publicly available rulesets.

[comius]

Actually I was thinking to change the implementation so that attribute is automatically added when there’s a transition.

The only problem is that I’d need it to either always point to @bazel_tools (simple) or add a flag to configure where it should point.

[comius]

Cc @gregestren