Skip to content

Commit d346fac

Browse files
committed
Revert "Revert "Try reacting to first time update instead IDK""
This reverts commit 7af06c6.
1 parent 7af06c6 commit d346fac

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/playbackstrategy/legacyplayeradapter.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import MediaState from "../models/mediastate"
33
import { ManifestType } from "../models/manifesttypes"
44
import AllowedMediaTransitions from "../allowedmediatransitions"
55
import LiveGlitchCurtain from "./liveglitchcurtain"
6-
// import MediaPlayerBase from "./modifiers/mediaplayerbase"
6+
import MediaPlayerBase from "./modifiers/mediaplayerbase"
77

88
function LegacyPlayerAdapter(mediaSources, playbackElement, isUHD, player) {
99
const manifestType = mediaSources.time().manifestType
@@ -238,15 +238,15 @@ function LegacyPlayerAdapter(mediaSources, playbackElement, isUHD, player) {
238238
setupExitSeekWorkarounds(mimeType)
239239
isPaused = false
240240

241-
// call pause upon metadata event firing
241+
// call pause upon STATUS event firing
242242
if (!autoPlay) {
243-
// mediaPlayer.addEventCallback(this, function pauseCallback(event) {
244-
// if (event.type === MediaPlayerBase.EVENT.METADATA) {
245-
// isPaused = true
246-
mediaPlayer.pause()
247-
// mediaPlayer.removeEventCallback(pauseCallback)
248-
// }
249-
// })
243+
mediaPlayer.addEventCallback(this, function pauseCallback(event) {
244+
if (event.type === MediaPlayerBase.EVENT.STATUS) {
245+
isPaused = true
246+
mediaPlayer.pause()
247+
mediaPlayer.removeEventCallback(pauseCallback)
248+
}
249+
})
250250
}
251251

252252
hasStartTime = presentationTimeInSeconds || presentationTimeInSeconds === 0

src/playbackstrategy/legacyplayeradapter.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,12 +291,12 @@ describe("Legacy Playback Adapter", () => {
291291
)
292292
})
293293

294-
it("calls pause when the METADATA event is emitted and player should pause after load", async () => {
294+
it("calls pause when the STATUS event is emitted and player should pause after load", async () => {
295295
const mediaPlayer = createMockMediaPlayer()
296296
const legacyAdapter = LegacyAdapter(mockMediaSources, playbackElement, false, mediaPlayer)
297297
legacyAdapter.load("video/mp4", null, false)
298298

299-
mediaPlayer.dispatchEvent({ type: MediaPlayerEvent.METADATA })
299+
mediaPlayer.dispatchEvent({ type: MediaPlayerEvent.STATUS })
300300

301301
expect(legacyAdapter.isPaused()).toBe(true)
302302
expect(mediaPlayer.pause).toHaveBeenCalled()

0 commit comments

Comments
 (0)