Skip to content

Typhoeus::Response#effective_url should be a string, Addressable::URI returned #552

Description

@erwanlr

Related to #540

As mentioned in the Typhoeus' doc, the effective_url method should return a string: https://github.com/typhoeus/typhoeus/blob/de61860fecec32b58e150e63219d1a4062a77855/lib/typhoeus/response/informations.rb#L181

Currently in webmock, an Addressable::URI object is returned

The fix would be to replace

:effective_url => request_signature.uri
by :effective_url => request_signature.uri.to_s

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions