Skip to content

Commit 5170422

Browse files
committed
fix: hide 'Add external credential (advanced)' from the proof screen list
There's no equivalent way yet to add/remove showcase-managed credentials from an already-created proof, so exposing only the external/advanced add-flow here was inconsistent and confusing. Editing an existing external credential via the gear icon still works; only the standalone add button is removed until parity is added for regular credentials.
1 parent 30c8531 commit 5170422

1 file changed

Lines changed: 0 additions & 42 deletions

File tree

frontend/src/admin/components/showcase/scenarios/ScenarioScreenRow.tsx

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ export function ScenarioScreenRow({
6363
const canEdit = useHasRole('creator')
6464
const [editingCredIdx, setEditingCredIdx] = useState<number | null>(null)
6565
const [editingExternalIdx, setEditingExternalIdx] = useState<number | null>(null)
66-
const [isAddingExternalCredential, setIsAddingExternalCredential] = useState(false)
6766
const [selectedAttributes, setSelectedAttributes] = useState<Map<string, any>>(new Map())
6867
const [editingCredential, setEditingCredential] = useState<Credential | null>(null)
6968
const [isVerifierIconEditOpen, setIsVerifierIconEditOpen] = useState(false)
@@ -387,14 +386,6 @@ export function ScenarioScreenRow({
387386
))}
388387
</div>
389388
)}
390-
{canEdit && (
391-
<button
392-
onClick={() => setIsAddingExternalCredential(true)}
393-
className="mt-3 w-full px-3 py-2 text-sm text-bcgov-blue border border-bcgov-blue rounded-lg hover:bg-blue-50"
394-
>
395-
Add external credential (advanced)
396-
</button>
397-
)}
398389
</div>
399390
</div>
400391
) : null
@@ -419,39 +410,6 @@ export function ScenarioScreenRow({
419410
/>
420411

421412
{/* Edit Proof Request Modal */}
422-
{isAddingExternalCredential && (
423-
<ExternalCredentialRequestModal
424-
isOpen={true}
425-
onClose={() => setIsAddingExternalCredential(false)}
426-
onSave={async (request) => {
427-
try {
428-
const updatedScenarios = showcase.scenarios.map((scenario) => {
429-
if (scenario.id !== scenarioId) return scenario
430-
return {
431-
...scenario,
432-
screens: scenario.screens.map((scenarioScreen) => {
433-
if (scenarioScreen.screenId !== nextScreen?.screenId || !scenarioScreen.requestOptions) {
434-
return scenarioScreen
435-
}
436-
return {
437-
...scenarioScreen,
438-
requestOptions: {
439-
...scenarioScreen.requestOptions,
440-
requestedCredentials: [...scenarioScreen.requestOptions.requestedCredentials, request],
441-
},
442-
}
443-
}),
444-
}
445-
})
446-
await updateShowcase(auth, showcase.name, { scenarios: updatedScenarios })
447-
await onRefreshShowcase?.()
448-
setIsAddingExternalCredential(false)
449-
} catch (error) {
450-
logger.error('Error adding external proof request:', error)
451-
}
452-
}}
453-
/>
454-
)}
455413
{editingExternalIdx !== null && nextScreen?.requestOptions?.requestedCredentials?.[editingExternalIdx] && (
456414
<ExternalCredentialRequestModal
457415
isOpen={true}

0 commit comments

Comments
 (0)