Skip to content

Commit c210c80

Browse files
committed
Added eligible flags
1 parent 0981210 commit c210c80

3 files changed

Lines changed: 10 additions & 23 deletions

File tree

api/src/main/java/ca/bc/gov/educ/api/graduation/model/dto/EdwGraduationSnapshot.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,5 @@ public class EdwGraduationSnapshot {
3535

3636
private String schoolOfRecord;
3737
private UUID schoolOfRecordId;
38+
private String eligible;
3839
}

api/src/main/java/ca/bc/gov/educ/api/graduation/service/EdwSnapshotService.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public EdwGraduationSnapshot processSnapshot(EdwGraduationSnapshot snapshotReque
5959
boolean isGraduated = StringUtils.isNotBlank(graduatedDate);
6060
if (isGraduated) {
6161
// retrieve honour_flag, gpa
62-
snapshot = populateSnapshot(gradYear, pen, graduatedDate, "Y", snapshotRequest.getHonoursStanding(), snapshotRequest.getGpa(), schoolOfRecord, schoolOfRecordId);
62+
snapshot = populateSnapshot(gradYear, pen, graduatedDate, "Y", snapshotRequest.getHonoursStanding(), snapshotRequest.getGpa(), schoolOfRecord, schoolOfRecordId, null);
6363
} else {
6464
snapshot = runHypotheticalGradAlgorithm(pen, gradYear, schoolOfRecord, schoolOfRecordId);
6565
}
@@ -95,11 +95,11 @@ private EdwGraduationSnapshot runHypotheticalGradAlgorithm(String pen, Integer g
9595
String gpaStr = graduationData.getGradStatus().getGpa();
9696
BigDecimal gpa = NumberUtils.isCreatable(gpaStr)? new BigDecimal(gpaStr) : null;
9797
String honoursStanding = graduationData.getGradStatus().getHonoursStanding();
98-
snapshot = populateSnapshot(gradYear, pen, null, "Y", honoursStanding, gpa, schoolOfRecord, schoolOfRecordId);
98+
snapshot = populateSnapshot(gradYear, pen, null, "N", honoursStanding, gpa, schoolOfRecord, schoolOfRecordId, "Y");
9999
} else {
100100
// non-graduated student
101101
log.debug(" ==> Not Graduated!");
102-
snapshot = populateSnapshot(gradYear, pen, null, "N", null, BigDecimal.ZERO, schoolOfRecord, schoolOfRecordId);
102+
snapshot = populateSnapshot(gradYear, pen, null, "N", null, BigDecimal.ZERO, schoolOfRecord, schoolOfRecordId, "N");
103103
}
104104
return snapshot;
105105
}
@@ -128,7 +128,7 @@ public GradSearchStudent getStudentByPenFromStudentApi(String pen) {
128128
return null;
129129
}
130130

131-
private EdwGraduationSnapshot populateSnapshot(Integer gradYear, String pen, String graduatedDate, String gradFlag, String honourFlag, BigDecimal gpa, String schoolOfRecord, UUID schoolOfRecordId) {
131+
private EdwGraduationSnapshot populateSnapshot(Integer gradYear, String pen, String graduatedDate, String gradFlag, String honourFlag, BigDecimal gpa, String schoolOfRecord, UUID schoolOfRecordId, String eligible) {
132132
EdwGraduationSnapshot obj = new EdwGraduationSnapshot();
133133
obj.setGradYear(gradYear);
134134
obj.setPen(pen);
@@ -138,6 +138,7 @@ private EdwGraduationSnapshot populateSnapshot(Integer gradYear, String pen, Str
138138
obj.setGraduatedDate(graduatedDate);
139139
obj.setSchoolOfRecord(schoolOfRecord);
140140
obj.setSchoolOfRecordId(schoolOfRecordId);
141+
obj.setEligible(eligible);
141142
return obj;
142143
}
143144
}

api/src/test/java/ca/bc/gov/educ/api/graduation/service/EdwSnapshotServiceTest.java

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import ca.bc.gov.educ.api.graduation.util.EducGraduationApiConstants;
55
import ca.bc.gov.educ.api.graduation.util.GradValidation;
66
import ca.bc.gov.educ.api.graduation.util.JsonTransformer;
7-
import org.junit.After;
87
import org.junit.Before;
98
import org.junit.Test;
109
import org.junit.runner.RunWith;
@@ -40,21 +39,9 @@ public class EdwSnapshotServiceTest {
4039
@MockBean
4140
GradStatusService gradStatusService;
4241

43-
@MockBean
44-
ReportService reportService;
45-
4642
@MockBean
4743
RESTService restService;
4844

49-
@Autowired
50-
JsonTransformer jsonTransformer;
51-
52-
@Autowired
53-
GradValidation validation;
54-
55-
@Autowired
56-
private ExceptionMessage exception;
57-
5845
@Autowired
5946
private EducGraduationApiConstants constants;
6047

@@ -71,11 +58,6 @@ public void setUp() {
7158
openMocks(this);
7259
}
7360

74-
@After
75-
public void tearDown() {
76-
77-
}
78-
7961
@Test
8062
public void testProcessSnapshotForGradStudent() {
8163
UUID schoolOfRecordId = UUID.randomUUID();
@@ -92,6 +74,7 @@ public void testProcessSnapshotForGradStudent() {
9274
assertThat(result.getPen()).isEqualTo(snapshotRequest.getPen());
9375
assertThat(result.getGraduationFlag()).isEqualTo("Y");
9476
assertThat(result.getSchoolOfRecordId()).isEqualTo(schoolOfRecordId);
77+
assertThat(result.getEligible()).isNull();
9578
}
9679

9780
@Test
@@ -129,6 +112,7 @@ public void testProcessSnapshotForNonGradStudent() {
129112
assertThat(result.getPen()).isEqualTo(snapshotRequest.getPen());
130113
assertThat(result.getGraduationFlag()).isEqualTo("N");
131114
assertThat(result.getSchoolOfRecordId()).isEqualTo(schoolOfRecordId);
115+
assertThat(result.getEligible()).isEqualTo("N");
132116
}
133117

134118
@Test
@@ -170,9 +154,10 @@ public void testProcessSnapshotForHypotheticalGradStudent() {
170154
var result = edwSnapshotService.processSnapshot(snapshotRequest);
171155
assertNotNull(result);
172156
assertThat(result.getPen()).isEqualTo(snapshotRequest.getPen());
173-
assertThat(result.getGraduationFlag()).isEqualTo("Y");
157+
assertThat(result.getGraduationFlag()).isEqualTo("N");
174158
assertThat(result.getGpa()).isEqualByComparingTo("3.80");
175159
assertThat(result.getHonoursStanding()).isEqualTo("Y");
176160
assertThat(result.getSchoolOfRecordId()).isEqualTo(schoolOfRecordId);
161+
assertThat(result.getEligible()).isEqualTo("Y");
177162
}
178163
}

0 commit comments

Comments
 (0)