Testing transactionals to fix delete student courses error

Author: mightycox

api/src/main/java/ca/bc/gov/educ/api/pen/replication/service/StudentCourseUpdateService.java

@@ -14,6 +14,8 @@
 import lombok.val;
 import org.apache.commons.lang3.StringUtils;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Propagation;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -45,6 +47,7 @@ public StudentCourseUpdateService(final EntityManagerFactory emf, final EventRep
    * @param event the event
    */
   @Override
+  @Transactional(propagation = Propagation.REQUIRES_NEW)
   public void processEvent(final StudentCourseUpdate studentCourseUpdate, final Event event) {
     var studentPEN = restUtils.getStudentPen(studentCourseUpdate.getStudentID());
     val existingTraxStudentRecord = this.traxStudentService.findTraxStudentByPen(StringUtils.rightPad(studentPEN, 10));

api/src/main/java/ca/bc/gov/educ/api/pen/replication/service/TraxStudentCourseService.java

@@ -1,15 +1,13 @@
 package ca.bc.gov.educ.api.pen.replication.service;
 
 import ca.bc.gov.educ.api.pen.replication.model.TraxStudentCourseEntity;
-import ca.bc.gov.educ.api.pen.replication.model.TraxStudentEntity;
 import ca.bc.gov.educ.api.pen.replication.repository.TraxStudentCourseRepository;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Propagation;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
-import java.util.Optional;
 
 @Service
 @Slf4j
@@ -26,7 +24,7 @@ public List<TraxStudentCourseEntity> findTraxStudentCoursesByPen(final String pe
   }
 
   // it is saved in a new transaction to make sure commit happens in DB.
-  @Transactional(propagation = Propagation.REQUIRES_NEW)
+  @Transactional(propagation = Propagation.REQUIRED)
   public void deletePriorAndSaveTraxStudentCourses(final List<TraxStudentCourseEntity> existingCourseList, final List<TraxStudentCourseEntity> studentCourseEntityList) {
     try {
       if(!existingCourseList.isEmpty()) {