Merge pull request #117 from bcgov/fix/student-course-deletion

Search student courses by pen with white space

Author: arcshiftsolutions

api/src/main/java/ca/bc/gov/educ/api/pen/replication/service/StudentCourseUpdateService.java

@@ -49,7 +49,7 @@ public void processEvent(final StudentCourseUpdate studentCourseUpdate, final Ev
     var studentPEN = restUtils.getStudentPen(studentCourseUpdate.getStudentID());
     val existingTraxStudentRecord = this.traxStudentService.findTraxStudentByPen(StringUtils.rightPad(studentPEN, 10));
     if (existingTraxStudentRecord.isPresent()) {
-      var existingCourses = this.traxStudentCourseService.findTraxStudentCoursesByPen(studentPEN);
+      var existingCourses = this.traxStudentCourseService.findTraxStudentCoursesByPen(StringUtils.rightPad(studentPEN, 10));
       existingCourses = existingCourses.stream().filter(Objects::nonNull).toList();
       this.traxStudentCourseService.deletePriorAndSaveTraxStudentCourses(existingCourses, getStudentCourseEntityList(studentPEN, studentCourseUpdate.getStudentCourses(), existingCourses));
       log.info("Processing choreography update event with ID {} :: payload is: {}", event.getEventId(), studentCourseUpdate);