Merge pull request #4123 from bcgov/fix/taskid-case

fix: use correct kebab-case for task_ids in dags

Author: joshgamache

dags/bc_obps_reset_data.py

@@ -41,7 +41,7 @@ def reset_data_task():
         trigger_k8s_cronjob("reset-database", BCIERS_NAMESPACE)
 
     cycle_backend_pod_task = KubernetesJobOperator(
-        task_id="cycle_backend_pod",
+        task_id="cycle-backend-pod",
         name="cycle-backend-pod",
         namespace=BCIERS_NAMESPACE,
         service_account_name=SERVICE_ACCOUNT_NAME,
@@ -53,7 +53,7 @@ def reset_data_task():
 
     # Triggers a check to see if the backend rollout has completed, but does not block the helm release use of the DAG
     trigger_wait_for_backend_rollout = TriggerDagRunOperator(
-        task_id="trigger_wait_for_backend_rollout",
+        task_id="trigger-wait-for-backend-rollout",
         trigger_dag_id=WAIT_FOR_BACKEND_ROLLOUT_DAG_NAME,
     )
 
@@ -74,7 +74,7 @@ def reset_data_task():
 )
 def wait_for_backend_rollout():
     wait_for_backend_rollout_task = KubernetesJobOperator(
-        task_id="wait_for_backend_rollout",
+        task_id="wait-for-backend-rollout",
         name="wait-for-backend-rollout",
         namespace=BCIERS_NAMESPACE,
         service_account_name=SERVICE_ACCOUNT_NAME,

dags/bc_obps_test_migrations.py

@@ -63,7 +63,7 @@ def trigger_k8s_cronjob_with_params(job_name_template, **context):
         trigger_k8s_cronjob(job_name, namespace)
 
     postgres_helm_install = KubernetesJobOperator(
-        task_id="install_cas_obps_postgres_migration_test_chart",
+        task_id="install-cas-obps-postgres-migration-test-chart",
         name="install-cas-obps-postgres-migration-test-chart",
         namespace="{{ params.destination_namespace }}",
         service_account_name=SERVICE_ACCOUNT_NAME,
@@ -84,21 +84,21 @@ def trigger_k8s_cronjob_with_params(job_name_template, **context):
     )
 
     time_delay_postgres = TimeDeltaSensor(
-        task_id="wait_time_before_postgres_initial_ready_check",
+        task_id="wait-time-before-postgres-initial-ready-check",
         delta=timedelta(minutes=8),
         doc_md="""Waits for 8 minutes before checking if the postgres pod is ready.""",
     )
 
-    wait_for_postgres_restore = trigger_k8s_cronjob_with_params.override(task_id="wait_for_postgres_restore")(
+    wait_for_postgres_restore = trigger_k8s_cronjob_with_params.override(task_id="wait-for-postgres-restore")(
         "pg-migration-test-wait-for-postgres-restore-job"
     )
 
-    postgres_migration_test = trigger_k8s_cronjob_with_params.override(task_id="postgres_migration_test")(
+    postgres_migration_test = trigger_k8s_cronjob_with_params.override(task_id="postgres-migration-test")(
         "pg-migration-test-job"
     )
 
     backend_helm_install = KubernetesJobOperator(
-        task_id="install_cas_obps_backend_migration_test_chart",
+        task_id="install-cas-obps-backend-migration-test-chart",
         name="install-cas-obps-backend-migration-test-chart",
         namespace="{{ params.destination_namespace }}",
         service_account_name=SERVICE_ACCOUNT_NAME,
@@ -120,21 +120,21 @@ def trigger_k8s_cronjob_with_params(job_name_template, **context):
     )
 
     time_delay_backend = TimeDeltaSensor(
-        task_id="wait_time_before_backend_initial_ready_check",
+        task_id="wait-time-before-backend-initial-ready-check",
         delta=timedelta(seconds=150),
         doc_md="""Waits for 150 seconds (based on the initial ready check time set in the backend) before checking if the backend pod is ready.""",
     )
 
-    wait_for_backend = trigger_k8s_cronjob_with_params.override(task_id="wait_for_backend")(
+    wait_for_backend = trigger_k8s_cronjob_with_params.override(task_id="wait-for-backend")(
         "be-migration-test-wait-for-backend-job"
     )
 
-    backend_migration_test = trigger_k8s_cronjob_with_params.override(task_id="backend_migration_test")(
+    backend_migration_test = trigger_k8s_cronjob_with_params.override(task_id="backend-migration-test")(
         "be-migration-test-job"
     )
 
     uninstall_postgres_helm_charts = KubernetesJobOperator(
-        task_id="uninstall_postgres_helm_charts",
+        task_id="uninstall-postgres-helm-charts",
         name="uninstall-postgres-helm-charts",
         namespace="{{ params.destination_namespace }}",
         service_account_name=SERVICE_ACCOUNT_NAME,
@@ -149,7 +149,7 @@ def trigger_k8s_cronjob_with_params(job_name_template, **context):
     )
 
     uninstall_backend_helm_charts = KubernetesJobOperator(
-        task_id="uninstall_backend_helm_charts",
+        task_id="uninstall-backend-helm-charts",
         name="uninstall-backend-helm-charts",
         namespace="{{ params.destination_namespace }}",
         service_account_name=SERVICE_ACCOUNT_NAME,