chore: cleanup

Author: shon-button

bc_obps/reporting/tests/api_v2/validation/test_report_validation_data.py

@@ -50,7 +50,19 @@ def test_get_returns_empty_validation_payload_when_no_errors(self):
                 self.endpoint_under_test,
             )
 
-        assert response.json() == {"errors": []}
+        response_json = response.json()
+
+        assert response_json["payload"] == {"errors": []}
+        assert response_json["report_data"] == {
+            "reporting_year": self.report_version.report.reporting_year_id,
+            "report_version_id": self.report_version.id,
+        }
+        assert response_json["operation_data"] == {
+            "naics_code": self.report_version.report.operation.naics_code.naics_code,
+            "operation_type": self.report_version.report.operation.type,
+            "is_operation_opted_out": False,
+        }
+
         mock_validate.assert_called_once()
 
     def test_get_returns_validation_errors_with_context(self):
@@ -99,7 +111,9 @@ def test_get_returns_validation_errors_with_context(self):
                 self.endpoint_under_test,
             )
 
-        assert response.json() == {
+        response_json = response.json()
+
+        assert response_json["payload"] == {
             "errors": [
                 {
                     "key": "error_required_fields",
@@ -133,6 +147,18 @@ def test_get_returns_validation_errors_with_context(self):
                 },
             ],
         }
+
+        assert response_json["report_data"] == {
+            "reporting_year": self.report_version.report.reporting_year_id,
+            "report_version_id": self.report_version.id,
+        }
+
+        assert response_json["operation_data"] == {
+            "naics_code": self.report_version.report.operation.naics_code.naics_code,
+            "operation_type": self.report_version.report.operation.type,
+            "is_operation_opted_out": False,
+        }
+
         mock_validate.assert_called_once()
 
     def test_validates_report_version_id(self):

bciers/apps/reporting/src/app/components/validation/ValidationPage.tsx

@@ -37,6 +37,7 @@ export default async function ValidationPage({
   let validationErrors: ReportValidationErrors = [];
   try {
     const response = await getReportValidationData(version_id);
+    console.log(response);
     validationErrors = response.errors;
   } catch (error) {
     // eslint-disable-next-line no-console