test: fixing tests

Author: pbastia

bc_obps/reporting/service/report_validation/validators/reporting_configuration_validator.py

@@ -60,7 +60,7 @@ def validate_reporting_fields(report_version: ReportVersion) -> dict[str, Report
         allowed_slugs = set(record.allowed_slugs)
 
         if not reported_slugs.issubset(allowed_slugs):
-            raise SystemError(
+            raise InternalSystemError(
                 f"ReportMethodology ID {record.id} has reporting fields {reported_slugs - allowed_slugs} which are not in the allowed fields {allowed_slugs} of its matching configuration element."
             )
 

bc_obps/reporting/tests/service/report_validation/validators/test_reporting_configuration_validator.py

@@ -29,7 +29,7 @@ def test_raises_if_no_configuration_element_present(self):
         )
 
         with pytest.raises(
-            SystemError,
+            InternalSystemError,
             match=f"Missing configuration elements for report methodology IDs: {report_methodology.id}",
         ):
             self.validator_under_test.validate(self.report_version)