fix: Resolve frontend ng8107 strict warnings (#1044)

Author: ianliuwk1019

admin/src/app/analytics-dashboard/analytics-dashboard.component.html

@@ -92,7 +92,7 @@ <h1 class="text-muted mb-0">Dashboard</h1>
                   Total FOMs published for public comments
                 </div>
                 <div class="total-fom-content-value">
-                  {{ analyticsData()?.nonInitialPublishedProjectCount || 0 }}
+                  {{ analyticsData().nonInitialPublishedProjectCount || 0 }}
                 </div>
               </div>
             </div>
@@ -191,7 +191,7 @@ <h1 class="text-muted mb-0">Dashboard</h1>
         <div class="unique-fc-box">
           <div>Unique forest clients submitting FOMs</div>
           <div class="unique-fc-vtxt">
-            {{ analyticsData()?.uniqueForestClientCount || 0 }}
+            {{ analyticsData().uniqueForestClientCount || 0 }}
           </div>
         </div>
         <div id="foms-by-forest-client" class="mt-3">

admin/src/app/foms/fom-detail/fom-detail.component.html

@@ -100,7 +100,7 @@ <h2>Details</h2>
                             <span class="name">FSP ID:</span>
                             <span
                               class="value">
-                              {{project()?.fspId}}
+                              {{project().fspId}}
                             </span>
                           </li>
                         }
@@ -109,7 +109,7 @@ <h2>Details</h2>
                             <span class="name">Woodlot Licence Number:</span>
                             <span
                               class="value">
-                              {{project()?.woodlotLicenseNumber}}
+                              {{project().woodlotLicenseNumber}}
                             </span>
                           </li>
                         }
@@ -134,7 +134,7 @@ <h2>Details</h2>
                           <span class="name">District:</span>
                           <span
                             class="value">
-                            {{project().district ? project().district?.name : 'A district has not been specified'}}
+                            {{project().district ? project().district.name : 'A district has not been specified'}}
                           </span>
                         </li>
                         <li>

admin/src/app/foms/fom-detail/fom-detail.component.ts

@@ -58,9 +58,9 @@ export class FomDetailComponent implements OnInit {
    * value — safe here because the constructor opts this route out of component reuse, so a new
    * FOM always means a new component instance.
    */
-  readonly project = linkedSignal<ProjectResponse>(() => this.projectDetail()!);
+  readonly project = linkedSignal<ProjectResponse>(() => this.projectDetail());
   // Route resolver data, bound as inputs (a/:appId resolve keys).
-  readonly projectDetail = input<ProjectResponse>();
+  readonly projectDetail = input.required<ProjectResponse>();
   readonly spatialDetail = input.required<SpatialFeaturePublicResponse[]>();
   readonly projectMetrics = input.required<ProjectMetricsResponse>();
   public isProjectActive = false;

admin/src/app/foms/fom-submission/fom-submission.component.html

@@ -98,18 +98,16 @@ <h1 class="text-muted">{{project()?.projectPlanCode == projectPlanCodeEnum.Fsp
               </div>
             </fieldset>
             @if (spatialSubmission(); as sub) {
-              @if (sub.cutblocks?.count > 0
-              || sub.roadSections?.count > 0
-              || sub.retentionAreas?.count > 0) {
+              @if (sub.cutblocks || sub.roadSections || sub.retentionAreas) {
               <fieldset class="no-margin no-border"
                 >
                 <legend> Submitted Spatial Objects </legend>
                 <ul class="nv-list">
-                  @if (sub.cutblocks?.count > 0) {
+                  @if (sub.cutblocks; as cutblocks) {
                     <li
                       style="padding-bottom: 0">
-                      <span class="name">Cut block submission - {{sub.cutblocks.count}} blocks</span>
-                      <span class="value1">{{sub.cutblocks.dateSubmitted | date}}</span>
+                      <span class="name">Cut block submission - {{cutblocks.count}} blocks</span>
+                      <span class="value1">{{cutblocks.dateSubmitted | date}}</span>
                       <span class="action">
                         @if (canDeleteSpatialSubmission()) {
                           <button class="btn btn-icon no-padding no-border" title="Remove Cutblocks"
@@ -127,11 +125,11 @@ <h1 class="text-muted">{{project()?.projectPlanCode == projectPlanCodeEnum.Fsp
                       </span>
                     </li>
                   }
-                  @if (sub.roadSections?.count > 0) {
+                  @if (sub.roadSections; as roadSections) {
                     <li
                       style="padding-bottom: 0">
-                      <span class="name">Road section submission - {{sub.roadSections.count}} sections</span>
-                      <span class="value1">{{sub.roadSections.dateSubmitted | date}}</span>
+                      <span class="name">Road section submission - {{roadSections.count}} sections</span>
+                      <span class="value1">{{roadSections.dateSubmitted | date}}</span>
                       <span class="action">
                         @if (canDeleteSpatialSubmission()) {
                           <button class="btn btn-icon no-padding no-border" title="Remove Road Sections"
@@ -149,11 +147,11 @@ <h1 class="text-muted">{{project()?.projectPlanCode == projectPlanCodeEnum.Fsp
                       </span>
                     </li>
                   }
-                  @if (sub.retentionAreas?.count > 0) {
+                  @if (sub.retentionAreas; as retentionAreas) {
                     <li
                       style="padding-bottom: 0">
-                      <span class="name">Retention area submission - {{sub.retentionAreas.count}} areas</span>
-                      <span class="value1">{{sub.retentionAreas.dateSubmitted | date}}</span>
+                      <span class="name">Retention area submission - {{retentionAreas.count}} areas</span>
+                      <span class="value1">{{retentionAreas.dateSubmitted | date}}</span>
                       <span class="action">
                         @if (canDeleteSpatialSubmission()) {
                           <button class="btn btn-icon no-padding no-border" title="Remove Retention Areas"

admin/src/app/foms/interactions/interactions.component.html

@@ -66,10 +66,14 @@ <h2 style="margin: 0;">Engagements ({{data.length}})</h2>
             <div class="panel-scroll">
               <app-interaction-detail #interactionDetailForm="interactionForm">
                 <div class="row">
-                  @if (canModifyInteraction()) {
+                  <!-- Also gated on interaction(): this button is projected into the child, but its
+                       bindings are evaluated in this view even while the child leaves the
+                       <ng-content> slot unrendered, and interactionFormGroup is not assigned until
+                       an interaction is selected. -->
+                  @if (canModifyInteraction() && interactionDetailForm.interaction()) {
                     <button type="button" title="Save this engagement"
                       class="btn btn-sm btn-primary btn-container"
-                      [disabled]="loadingSvc.loading() || interactionDetailForm.interactionFormGroup?.invalid"
+                      [disabled]="loadingSvc.loading() || interactionDetailForm.interactionFormGroup.invalid"
                       (click)="saveInteraction(interactionDetailForm.interactionFormGroup.value, interactionDetailForm.interaction())">
                       Save interaction
                     </button>

admin/src/app/foms/summary/summary.component.html

@@ -119,7 +119,7 @@ <h4>Geographic Shape Information</h4>
             </div>
           </section>
 
-          @if (!selectedScope()?.commentScopeCode) {
+          @if (!selectedScope().commentScopeCode) {
             <section>
               <div>
                 <app-interactions-summary [interactionDetails]="interactions()"
@@ -129,7 +129,7 @@ <h4>Geographic Shape Information</h4>
           }
         </section>
 
-        @if (!selectedScope()?.commentScopeCode) {
+        @if (!selectedScope().commentScopeCode) {
           <section>
             <h4>Attachments</h4>
             @if ((attachments()?.length ?? 0) > 0) {
@@ -173,7 +173,7 @@ <h4>Attachments</h4>
           </section>
         }
 
-        @if (!selectedScope()?.commentScopeCode) {
+        @if (!selectedScope().commentScopeCode) {
           <section>
             <small>
               {{project()?.projectPlanCode == projectPlanCodeEnum.Fsp

admin/src/app/search/search.component.html

@@ -146,7 +146,7 @@ <h2>
                         [innerHTML]="project.forestClient ? (project.forestClient.name | titlecase) : ''">
                       </td>
                       <td>
-                        {{project.district?.name}}
+                        {{project.district.name}}
                       </td>
                       <td>
                         {{project.workflowState? project.workflowState.description : 'Unknown'}}

api/openapi/swagger-spec.json

@@ -2956,8 +2956,6 @@
           "revisionCount",
           "createTimestamp",
           "commentScope",
-          "response",
-          "responseDetails",
           "scopeFeatureName"
         ]
       },
@@ -3193,10 +3191,7 @@
         "required": [
           "projectId",
           "submissionId",
-          "submissionTypeCode",
-          "cutblocks",
-          "roadSections",
-          "retentionAreas"
+          "submissionTypeCode"
         ]
       },
       "SubmissionTypeCode": {

api/src/app/modules/public-comment/public-comment.dto.ts

@@ -1,4 +1,4 @@
-import { ApiProperty, OmitType } from '@nestjs/swagger';
+import { ApiProperty, ApiPropertyOptional, OmitType } from '@nestjs/swagger';
 import {
   IsArray,
     IsEmail,
@@ -90,10 +90,11 @@ export class PublicCommentAdminResponse extends OmitType(
   @ApiProperty()
   commentScope: CommentScopeCode;
 
-  @ApiProperty()
+  // Optional: a comment that has not been actioned yet has no response code.
+  @ApiPropertyOptional()
   response?: ResponseCode;
 
-  @ApiProperty()
+  @ApiPropertyOptional()
   responseDetails?: string;
 
   @ApiProperty()

api/src/app/modules/submission/submission.dto.ts

@@ -1,4 +1,4 @@
-import { ApiProperty } from '@nestjs/swagger';
+import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import { IsEnum, IsNotEmpty } from 'class-validator';
 import { FeatureCollection } from 'geojson';
 import { SubmissionTypeCodeEnum } from './submission-type-code.entity';
@@ -78,12 +78,15 @@ export class SubmissionDetailResponse {
   })
   submissionTypeCode: SubmissionTypeCodeEnum;
 
-  @ApiProperty({type: SubmissionSpatialObjectDetail})
-  cutblocks: SubmissionSpatialObjectDetail; 
+  // All three are optional and only present when that spatial type was actually submitted:
+  // convertToSubmissionDetailResponse assigns each one only when its count is greater than zero
+  // (see submission.service.ts).
+  @ApiPropertyOptional({type: SubmissionSpatialObjectDetail})
+  cutblocks?: SubmissionSpatialObjectDetail;
 
-  @ApiProperty({type: SubmissionSpatialObjectDetail})
-  roadSections: SubmissionSpatialObjectDetail; 
+  @ApiPropertyOptional({type: SubmissionSpatialObjectDetail})
+  roadSections?: SubmissionSpatialObjectDetail;
 
-  @ApiProperty({type: SubmissionSpatialObjectDetail})
-  retentionAreas: SubmissionSpatialObjectDetail; 
+  @ApiPropertyOptional({type: SubmissionSpatialObjectDetail})
+  retentionAreas?: SubmissionSpatialObjectDetail;
 }