test(public-notice): add regression tests for null prefill and service query

Author: DerekRoberts

admin/src/app/foms/public-notice/public-notice-edit.component.spec.ts

@@ -35,6 +35,8 @@ describe('PublicNoticeEditComponent', () => {
   let fixture: ComponentFixture<PublicNoticeEditComponent>;
   let findOneMock: jest.Mock;
   let findLatestMock: jest.Mock;
+  let createMock: jest.Mock;
+  let updateMock: jest.Mock;
   let router: Router;
 
   const existingNotice = {
@@ -82,6 +84,8 @@ describe('PublicNoticeEditComponent', () => {
   beforeEach(async () => {
     findOneMock = jest.fn().mockReturnValue(asyncOf(existingNotice));
     findLatestMock = jest.fn().mockReturnValue(asyncOf(clientLatestNotice));
+    createMock = jest.fn().mockReturnValue(asyncOf({ id: 101 }));
+    updateMock = jest.fn().mockReturnValue(asyncOf({ id: 55 }));
 
     await TestBed.configureTestingModule({
       imports: [PublicNoticeEditComponent, NoopAnimationsModule],
@@ -92,6 +96,8 @@ describe('PublicNoticeEditComponent', () => {
           useValue: {
             publicNoticeControllerFindOne: findOneMock,
             publicNoticeControllerFindLatestPublicNotice: findLatestMock,
+            publicNoticeControllerCreate: createMock,
+            publicNoticeControllerUpdate: updateMock,
           },
         },
         { provide: CognitoService, useValue: { getUser: () => ({ isForestClient: true, isAuthorizedForClientId: () => true }) } },
@@ -165,13 +171,24 @@ describe('PublicNoticeEditComponent', () => {
       expect(findOneMock).not.toHaveBeenCalled();
     });
 
-    it('is treated as a new notice and renders an empty form', () => {
+    it('is treated as a new notice and renders an empty form with actions', () => {
       expect(component.isNewForm).toBe(true);
       expect(component.isAddNewNotice()).toBe(true);
       expect(component.publicNoticeResponse).toBeNull();
       expect(component.formReady()).toBe(true);
       expect(component.publicNoticeFormGroup).toBeDefined();
       expect(fixture.nativeElement.querySelector('form#publicNoticeForm')).not.toBeNull();
+      expect(fixture.nativeElement.querySelector('h1').textContent).toContain('New Online Public Notice');
+      expect(fixture.nativeElement.querySelector('h1').textContent).toContain('FOM Number: 2');
+      expect(fixture.nativeElement.querySelector('button[type="submit"]')).not.toBeNull();
+    });
+
+    it('submits a new public notice on valid form submission and navigates back', async () => {
+      const navSpy = jest.spyOn(router, 'navigate').mockResolvedValue(true);
+      await component.onSubmit();
+      expect(createMock).toHaveBeenCalledWith(expect.objectContaining({ projectId: 2 }));
+      expect(updateMock).not.toHaveBeenCalled();
+      expect(navSpy).toHaveBeenCalledWith(['/a', 2]);
     });
   });
 

api/src/app/modules/project/public-notice.service.spec.ts

@@ -218,6 +218,57 @@ describe('PublicNoticeService', () => {
 
     });
 
+    describe('findLatestPublicNotice', () => {
+      beforeEach(async () => {
+        user = new User();
+      });
+
+      it('throws ForbiddenException when user is not authorized', async () => {
+        user.isForestClient = true;
+        user.clientIds = ['different-client-id'];
+        await expect(service.findLatestPublicNotice('00001012', user)).rejects.toThrow();
+      });
+
+      it('returns null when no public notice is found for forest client', async () => {
+        user.isForestClient = true;
+        user.clientIds = ['00001012'];
+        const createQueryBuilder: any = {
+          select: () => createQueryBuilder,
+          addSelect: () => createQueryBuilder,
+          innerJoin: () => createQueryBuilder,
+          where: () => createQueryBuilder,
+          addOrderBy: () => createQueryBuilder,
+          limit: () => createQueryBuilder,
+          getOne: () => null,
+        };
+        jest.spyOn(repository, 'createQueryBuilder').mockImplementation(() => createQueryBuilder);
+
+        const result = await service.findLatestPublicNotice('00001012', user);
+        expect(result).toBeNull();
+      });
+
+      it('returns converted public notice response when a notice is found', async () => {
+        user.isForestClient = true;
+        user.clientIds = ['00001012'];
+        const sampleNotice = getSamplePublicNoticeEntity();
+        const createQueryBuilder: any = {
+          select: () => createQueryBuilder,
+          addSelect: () => createQueryBuilder,
+          innerJoin: () => createQueryBuilder,
+          where: () => createQueryBuilder,
+          addOrderBy: () => createQueryBuilder,
+          limit: () => createQueryBuilder,
+          getOne: () => sampleNotice,
+        };
+        jest.spyOn(repository, 'createQueryBuilder').mockImplementation(() => createQueryBuilder);
+
+        const result = await service.findLatestPublicNotice('00001012', user);
+        expect(result).toBeDefined();
+        expect(result.id).toBe(sampleNotice.id);
+        expect(result.projectId).toBe(sampleNotice.projectId);
+      });
+    });
+
 });
 
 export class PublicNoticeRepositoryFake {