fix(#2374): Add a validation in both BE and FE when there is no association between the legal type and client type (#2364)

* fix(#1120): Add a validation in both BE and FE, to prevent the user to create a client when there is no association between the legal type and client type

* Mapped BC registry legal type mapping with Oracle mapping

Author: mamartinezmejia

frontend/src/pages/bceidform/BusinessInformationWizardStep.vue

@@ -157,6 +157,12 @@ watch([autoCompleteResult], () => {
     formData.value.businessInformation.clientType = retrieveClientType(
       autoCompleteResult.value.legalType
     );
+
+    if (!formData.value.businessInformation.clientType) {
+      toggleErrorMessages(null, null, null, null, true);
+      return;
+    };
+    
     showAutoCompleteInfo.value = false;
 
     if (formData.value.businessInformation.clientType === 'RSP') {

frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue

@@ -63,6 +63,24 @@ const errorBus = useEventBus<ValidationMessageType[]>(
 const formData = ref<FormDataDto>(props.data);
 const showUnsupportedLegalTypeError = ref<boolean>(false); 
 
+const toggleErrorMessages = (
+  unsupportedLegalType: boolean | null = null,
+) => {
+  showUnsupportedLegalTypeError.value = unsupportedLegalType ?? false;
+
+  if (unsupportedLegalType) {
+    progressIndicatorBus.emit({ kind: "disabled", value: true });
+    exitBus.emit({
+      unsupportedLegalType
+    });
+  } else {
+    progressIndicatorBus.emit({ kind: "disabled", value: false });
+    exitBus.emit({
+      unsupportedLegalType: false
+    });
+  }
+};
+
 watch(
   () => formData.value,
   () => emit("update:data", formData.value)
@@ -146,30 +164,17 @@ watch([autoCompleteResult], () => {
     );
     formData.value.businessInformation.businessType = getEnumKeyByEnumValue(BusinessTypeEnum, BusinessTypeEnum.R);
 
+    if (!formData.value.businessInformation.clientType) {
+      toggleErrorMessages(true);
+      return;
+    }
+
     emit("update:data", formData.value);
 
     if (formData.value.businessInformation.clientType === "RSP") {
       validation.birthdate = false;
     }
 
-    const toggleErrorMessages = (
-      unsupportedLegalType: boolean | null = null,
-    ) => {
-      showUnsupportedLegalTypeError.value = unsupportedLegalType ?? false;
-
-      if (unsupportedLegalType) {
-        progressIndicatorBus.emit({ kind: "disabled", value: true });
-        exitBus.emit({
-          unsupportedLegalType
-        });
-      } else {
-        progressIndicatorBus.emit({ kind: "disabled", value: false });
-        exitBus.emit({
-          unsupportedLegalType: false
-        });
-      }
-    };
-
     //Also, we will load the backend data to fill all the other information as well
     const {
       error,
@@ -446,7 +451,7 @@ onMounted(() => {
       data-text="Client information"
       v-shadow="2"
       id="bcRegistrySearchNotification"
-      v-if="!formData.businessInformation.clientType"
+      v-if="!formData.businessInformation.clientType && !showUnsupportedLegalTypeError"
       low-contrast="true"
       open="true"
       kind="info"

legacy/src/test/java/ca/bc/gov/app/controller/ClientLocationControllerIntegrationTest.java

@@ -65,7 +65,7 @@ void shouldSaveLocation(String clientNumber) {
   }
 
   private static Stream<String> saveLocation() {
-    return Stream.of("00000001", "00000002", "00000008");
+    return Stream.of("00000001", "00000002", "00000005");
   }
 
   @ParameterizedTest