refactor(dto): rename bare CheckStatusResponse to Schedule<N>CheckStatusResponse (Story 29.12)

schedule1/2/3 each had a distinct check-status DTO sharing the bare name
CheckStatusResponse; schedules 4–11 already follow the Schedule<N>CheckStatusResponse
convention. Rename the three so every schedule's check-status DTO is grep-able and
unambiguous, matching the rest.

Pure rename (git mv + reference updates), scoped to the exact schedule1/2/3 packages.
Not a consolidation — the three types stay distinct (Sch1/Sch3 carry
requirementsMet/errors/warnings/message, Sch2 carries outcome/messages). No JSON wire
change: only the Java class name changed, record component (field) names are untouched;
no @Schema(name=...) or OpenAPI generator binds the class name.

Verified: full module test-compile + 318 schedule1/2/3 unit tests green; the
Schedule1/2/3 check-status ITs (which serialize these DTOs over HTTP) pass unchanged;
checkstyle main-source gate green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: gpascucci

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/Schedule1Controller.java

@@ -2,7 +2,7 @@
 
 import ca.bc.gov.nrs.ilcr.millcontext.MillContextService;
 import ca.bc.gov.nrs.ilcr.schedule1.api.Schedule1Api;
-import ca.bc.gov.nrs.ilcr.schedule1.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageInfo;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageResponse;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1Request;
@@ -81,7 +81,7 @@ public ResponseEntity<MessageResponse> deleteSchedule1(
 
   @Override
   @PreAuthorize("@permissions.hasPermission(authentication, 'VIEW_SCHEDULE')")
-  public ResponseEntity<CheckStatusResponse> checkStatus(
+  public ResponseEntity<Schedule1CheckStatusResponse> checkStatus(
       long millId, int year, Authentication authentication) {
     millContextService.validateScheduleViewable(millId, year, SCHEDULE_1_CATEGORY);
     return ResponseEntity.ok(schedule1Service.checkSchedule1Status(millId, year));

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/Schedule1Service.java

@@ -4,7 +4,7 @@
 import ca.bc.gov.nrs.ilcr.schedule1.Schedule1Repository.DetailRow;
 import ca.bc.gov.nrs.ilcr.schedule1.Schedule1Repository.OtherCostDetailRow;
 import ca.bc.gov.nrs.ilcr.schedule1.Schedule1Repository.SummaryRow;
-import ca.bc.gov.nrs.ilcr.schedule1.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.LineItem;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageInfo;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.OtherCostRequest;
@@ -619,7 +619,7 @@ private record CheckField(int code, String label, boolean checkVolume, boolean c
    * (missing mandatory fields + Other-Costs volume/cost consistency) block; the empty-cost row check is
    * a non-blocking warning. Verbatim messages composed server-side (AD-8), in legacy field order.
    */
-  public CheckStatusResponse checkSchedule1Status(long millId, int year) {
+  public Schedule1CheckStatusResponse checkSchedule1Status(long millId, int year) {
     SummaryRow summary = repository.findSummary(millId, year, SCHEDULE_1_CATEGORY)
         .orElseThrow(ScheduleNotFoundException::new);
     List<DetailRow> details = repository.findDetails(summary.summaryId());
@@ -653,7 +653,7 @@ public CheckStatusResponse checkSchedule1Status(long millId, int year) {
     MessageInfo message = requirementsMet
         ? new MessageInfo(MSG_REQUIREMENTS_MET, resolveText(MSG_REQUIREMENTS_MET))
         : null;
-    return new CheckStatusResponse(requirementsMet, errors, warnings, message);
+    return new Schedule1CheckStatusResponse(requirementsMet, errors, warnings, message);
   }
 
   /** First stored detail row per (non-Other) cost-item code; later duplicates are ignored. */

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/api/Schedule1Api.java

@@ -1,6 +1,6 @@
 package ca.bc.gov.nrs.ilcr.schedule1.api;
 
-import ca.bc.gov.nrs.ilcr.schedule1.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageResponse;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1Request;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1Response;
@@ -78,6 +78,6 @@ ResponseEntity<MessageResponse> deleteSchedule1(
    * @return 200 with the check-status result (errors, warnings, requirements-met + success message)
    */
   @PostMapping("/check-status")
-  ResponseEntity<CheckStatusResponse> checkStatus(
+  ResponseEntity<Schedule1CheckStatusResponse> checkStatus(
       @RequestParam long millId, @RequestParam int year, Authentication authentication);
 }

…r/schedule1/dto/CheckStatusResponse.java …e1/dto/Schedule1CheckStatusResponse.javabackend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/dto/CheckStatusResponse.java renamed to backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/dto/Schedule1CheckStatusResponse.java backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/dto/CheckStatusResponse.java renamed to backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule1/dto/Schedule1CheckStatusResponse.java

@@ -14,7 +14,7 @@
  * @param warnings the non-blocking advisories (e.g. WRN-002 empty-cost row)
  * @param message the "all requirements met" success message when {@code requirementsMet}, else null
  */
-public record CheckStatusResponse(
+public record Schedule1CheckStatusResponse(
     boolean requirementsMet,
     List<MessageInfo> errors,
     List<MessageInfo> warnings,

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/Schedule2Controller.java

@@ -4,7 +4,7 @@
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageInfo;
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageResponse;
 import ca.bc.gov.nrs.ilcr.schedule2.api.Schedule2Api;
-import ca.bc.gov.nrs.ilcr.schedule2.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Request;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Response;
 import ca.bc.gov.nrs.ilcr.security.SchedulePermissions;
@@ -77,11 +77,11 @@ public ResponseEntity<MessageResponse> deleteSchedule2(
 
   @Override
   @PreAuthorize("@permissions.hasPermission(authentication, 'VIEW_SCHEDULE')")
-  public ResponseEntity<CheckStatusResponse> checkStatus(
+  public ResponseEntity<Schedule2CheckStatusResponse> checkStatus(
       long millId, int year, Authentication authentication) {
     // Read-only (AD-5): context guard first (no summary-required), then evaluate — mutates nothing.
     millContextService.validateMillYearActive(millId, year);
-    CheckStatusResponse status = schedule2Service.checkStatus(millId, year);
+    Schedule2CheckStatusResponse status = schedule2Service.checkStatus(millId, year);
     // Resolve each message's verbatim bundle text (AD-8), same as the save/delete success message. The
     // service carries an optional field label in MessageInfo.text; when present it is prefixed as
     // "<label>: <resolvedText>" (legacy Schedule2MB:168 + Schedule 1 valueRequired parity).
@@ -93,6 +93,6 @@ public ResponseEntity<CheckStatusResponse> checkStatus(
               : new MessageInfo(base.key(), m.text() + ": " + base.text());
         })
         .toList();
-    return ResponseEntity.ok(new CheckStatusResponse(status.outcome(), resolved));
+    return ResponseEntity.ok(new Schedule2CheckStatusResponse(status.outcome(), resolved));
   }
 }

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/Schedule2Service.java

@@ -9,7 +9,7 @@
 import ca.bc.gov.nrs.ilcr.schedule1.dto.Schedule1Response;
 import ca.bc.gov.nrs.ilcr.schedule2.Schedule2Repository.DetailRow;
 import ca.bc.gov.nrs.ilcr.schedule2.Schedule2Repository.SummaryRow;
-import ca.bc.gov.nrs.ilcr.schedule2.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.CostBlock;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Request;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Response;
@@ -386,7 +386,7 @@ public Schedule2Response getSchedule2(long millId, int year, boolean callerMayEd
    * @return the outcome + one message key (text resolved by the controller)
    */
   @Transactional(readOnly = true)
-  public CheckStatusResponse checkStatus(long millId, int year) {
+  public Schedule2CheckStatusResponse checkStatus(long millId, int year) {
     // callerMayEdit is irrelevant to BR-07 (only the item-25 cost matters); pass false.
     Schedule2Response document = getSchedule2(millId, year, false);
     boolean met = document.purchasedLogCost().cost() != null;
@@ -396,7 +396,7 @@ public CheckStatusResponse checkStatus(long millId, int year) {
     // resolved bundle text ("<label>: Value Required"), mirroring legacy Schedule2MB:168 + Schedule 1
     // (Schedule1Service.valueRequired). The MET message needs no label prefix.
     String labelPrefix = met ? null : LABEL_PURCHASED_LOG_COST;
-    return new CheckStatusResponse(outcome, List.of(new MessageInfo(key, labelPrefix)));
+    return new Schedule2CheckStatusResponse(outcome, List.of(new MessageInfo(key, labelPrefix)));
   }
 
   // -------------------------------------------------------------------------------------------------

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/api/Schedule2Api.java

@@ -1,7 +1,7 @@
 package ca.bc.gov.nrs.ilcr.schedule2.api;
 
 import ca.bc.gov.nrs.ilcr.schedule1.dto.MessageResponse;
-import ca.bc.gov.nrs.ilcr.schedule2.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Request;
 import ca.bc.gov.nrs.ilcr.schedule2.dto.Schedule2Response;
 import jakarta.validation.Valid;
@@ -83,9 +83,9 @@ ResponseEntity<MessageResponse> deleteSchedule2(
    * @param millId the mill id (required)
    * @param year the reporting year (required)
    * @param authentication the caller (authorized for VIEW_SCHEDULE)
-   * @return 200 with the {@link CheckStatusResponse} (outcome + resolved message)
+   * @return 200 with the {@link Schedule2CheckStatusResponse} (outcome + resolved message)
    */
   @PostMapping("/check-status")
-  ResponseEntity<CheckStatusResponse> checkStatus(
+  ResponseEntity<Schedule2CheckStatusResponse> checkStatus(
       @RequestParam long millId, @RequestParam int year, Authentication authentication);
 }

…r/schedule2/dto/CheckStatusResponse.java …e2/dto/Schedule2CheckStatusResponse.javabackend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/dto/CheckStatusResponse.java renamed to backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/dto/Schedule2CheckStatusResponse.java backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/dto/CheckStatusResponse.java renamed to backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule2/dto/Schedule2CheckStatusResponse.java

@@ -14,7 +14,7 @@
  * @param outcome {@code "MET"} or {@code "ISSUES"}
  * @param messages the user-facing message(s) for the outcome (key + resolved text)
  */
-public record CheckStatusResponse(
+public record Schedule2CheckStatusResponse(
     String outcome,
     List<MessageInfo> messages) {
 }

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule3/Schedule3Controller.java

@@ -2,7 +2,7 @@
 
 import ca.bc.gov.nrs.ilcr.millcontext.MillContextService;
 import ca.bc.gov.nrs.ilcr.schedule3.api.Schedule3Api;
-import ca.bc.gov.nrs.ilcr.schedule3.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule3.dto.Schedule3CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.MessageInfo;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.MessageResponse;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.Schedule3Request;
@@ -83,7 +83,7 @@ public ResponseEntity<MessageResponse> deleteSchedule3(
 
   @Override
   @PreAuthorize("@permissions.hasPermission(authentication, 'VIEW_SCHEDULE')")
-  public ResponseEntity<CheckStatusResponse> checkStatus(
+  public ResponseEntity<Schedule3CheckStatusResponse> checkStatus(
       long millId, int year, Authentication authentication) {
     millContextService.validateScheduleViewable(millId, year, SCHEDULE_3_CATEGORY);
     return ResponseEntity.ok(schedule3Service.checkSchedule3Status(millId, year));

backend/src/main/java/ca/bc/gov/nrs/ilcr/schedule3/Schedule3Service.java

@@ -10,7 +10,7 @@
 import ca.bc.gov.nrs.ilcr.schedule3.Schedule3Repository.DetailRow;
 import ca.bc.gov.nrs.ilcr.schedule3.Schedule3Repository.SubPageRow;
 import ca.bc.gov.nrs.ilcr.schedule3.Schedule3Repository.SummaryRow;
-import ca.bc.gov.nrs.ilcr.schedule3.dto.CheckStatusResponse;
+import ca.bc.gov.nrs.ilcr.schedule3.dto.Schedule3CheckStatusResponse;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.CostLine;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.MessageInfo;
 import ca.bc.gov.nrs.ilcr.schedule3.dto.OtherAcceptableDocument;
@@ -742,7 +742,7 @@ private Integer firstCost(int summaryId, int costItemCode) {
    * {@code Schedule3CheckStatus.isHarvestCostGreaterThanPopCost}). Verbatim labels/messages, legacy
    * field order (AD-8).
    */
-  public CheckStatusResponse checkSchedule3Status(long millId, int year) {
+  public Schedule3CheckStatusResponse checkSchedule3Status(long millId, int year) {
     SummaryRow summary = repository.findSummary(millId, year)
         .orElseThrow(ScheduleNotFoundException::new);
     List<DetailRow> details = repository.findDetails(summary.summaryId());
@@ -771,7 +771,7 @@ public CheckStatusResponse checkSchedule3Status(long millId, int year) {
     MessageInfo message = requirementsMet
         ? new MessageInfo(MSG_REQUIREMENTS_MET, resolveText(MSG_REQUIREMENTS_MET))
         : null;
-    return new CheckStatusResponse(requirementsMet, errors, List.of(), message);
+    return new Schedule3CheckStatusResponse(requirementsMet, errors, List.of(), message);
   }
 
   /**